test: MMQA - 1711 - [Mobile] Update Predict e2e tests to enable features that were disabled due to feature flag updates

[LeVinhGithub]

Description

Brings Predict E2E test feature flag mocks into parity with production values.

Two remote feature flag overrides in predict smoke tests diverged from production after a feature flag registry sync (PR #28444). This PR aligns the mocks:

• exploreSectionsOrder: Replaced the explicit section ordering arrays with {} in 4 predict smoke specs. On production this flag is empty; the app falls back to hardcoded defaults which produce the same layout. The Homepage component does not consume this flag at all — it only affects TrendingView/Explore, which these tests don't exercise.
• predictLiveSports: Added 'nba' to the leagues list (now ['nfl', 'nba']) to match production. This causes NBA markets (Spurs vs. Pelicans) to render via PredictGameDetailsContent, which uses a different cash-out button test ID (predict-picks-cash-out-button-{positionId}). Updated the PredictDetailsPage page object with a new tapGameCashOutButton(positionId) method and updated predict-cash-out.spec.ts to use it.

Changelog

CHANGELOG entry: null

Related issues

Fixes: MMQA-1711

Manual testing steps

Feature: Predict E2E prod parity

Scenario: Cash out on NBA game market uses correct button

• Given the predict smoke tests use production-parity feature flag mocks
• When the predict-cash-out test runs against Spurs vs. Pelicans
• Then the test taps the game-details cash-out button (PredictPickItem testID)
• And the cash-out flow completes successfully

Scenario: Predict tests work without explicit exploreSectionsOrder

• Given exploreSectionsOrder is set to {} in all predict smoke specs
• When any predict smoke test runs (cash-out, open-position, geo-restriction, withdraw)
• Then the Homepage renders with the default section order
• And the test navigates to predictions by test ID without issue

Screenshots/Recordings

Before

N/A — test-only changes, no UI impact.

After

N/A — test-only changes, no UI impact.

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Low Risk
Test-only changes that adjust feature-flag mocks and E2E selectors; low product risk, but could affect Predict smoke test stability if testIDs/position IDs drift.

Overview
Aligns Predict E2E remote feature-flag mocks with current production defaults by removing the predictLiveSports override from remoteFeatureFlagPredictEnabled.

Updates Predict smoke specs to interact with the game-details UI: adds a shared SPURS_PELICANS_POSITION_ID, introduces PredictDetailsPage.tapGameCashOutButton(positionId) and tapGameBetYesButton(), and switches cash-out/position-opening tests to use the new testIDs for NBA/game markets.

^{Reviewed by Cursor Bugbot for commit f452736. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.88%. Comparing base (8437791) to head (c7adb61).
⚠️ Report is 70 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #29154      +/-   ##
==========================================
+ Coverage   81.86%   81.88%   +0.01%     
==========================================
  Files        5255     5271      +16     
  Lines      138980   139465     +485     
  Branches    31518    31688     +170     
==========================================
+ Hits       113774   114198     +424     
- Misses      17465    17511      +46     
- Partials     7741     7756      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

AI PR Analysis

🚫 Merge safe: false | 🟠 Risk: high

Merge decision: AI analysis did not complete — manual review required before merging.

AI analysis did not complete. Manual review recommended.

View run

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit c564cee. Configure here.}

[cortisiko]

@LeVinhGithub the PR looks good, but there are failing tests. can you have a look when you get a chance ?

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokePredictions, SmokeWalletPlatform, SmokeConfirmations
• Selected Performance tags: None (no tests recommended)
• Risk Level: medium
• AI Confidence: 95%

click to see 🤖 AI reasoning details

E2E Test Selection:
All 6 changed files are exclusively within the E2E test infrastructure (tests/ directory) — no app source code was modified. The changes focus on:

1. feature-flags-mocks.ts: Removed the predictLiveSports feature flag exclusion that was previously blocking NBA markets from E2E tests. This enables sports game markets (like NBA) to be tested.

2. polymarket-constants.ts: Added SPURS_PELICANS_POSITION_ID constant for a specific Polymarket position ID used in the Spurs vs. Pelicans game test scenario.

3. PredictDetailsPage.ts: Extended the page object with new methods to support game-type prediction markets: gameBetYesButton, getGameCashOutButton(positionId), tapGameCashOutButton(positionId), and tapGameBetYesButton(). These use new test IDs from PredictGameDetailsFooter, PredictActionButtons, PredictBetButtons, and PredictPickItem components.

4. predict-cash-out.spec.ts: Updated to use tapGameCashOutButton(SPURS_PELICANS_POSITION_ID) instead of the generic tapCashOutButton(), supporting the game-specific cash-out flow.

5. predict-geo-restriction.spec.ts: Same cash-out button update plus added analytics helpers for geo-blocked cashout expectations.

6. predict-open-position.spec.ts: Updated to use tapGameBetYesButton() instead of tapOpenPositionValue(), and removed assertions about position tab visibility that no longer apply to the game market flow.

Tag selection rationale:

• SmokePredictions: Directly required — all 3 predict smoke test specs are modified and need validation.
• SmokeWalletPlatform: Required per SmokePredictions tag description: "Predictions is also a section inside the Trending tab (SmokeWalletPlatform); changes to Predictions views affect Trending. When selecting SmokePredictions, also select SmokeWalletPlatform."
• SmokeConfirmations: Required per SmokePredictions tag description: "opening/closing positions are on-chain transactions. When selecting SmokePredictions, also select SmokeConfirmations."

Performance Test Selection:
All changes are exclusively within the E2E test infrastructure (tests/ directory). No app source code, components, controllers, or performance-sensitive code was modified. There is no performance impact from these changes.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud