Skip to content

chore: TSA-426. Refactor quickbuy to use Bridge FetchQuotes#29157

Closed
joaosantos15 wants to merge 3 commits into
mainfrom
TSA-426-quickbuy-fetchquotes-partial
Closed

chore: TSA-426. Refactor quickbuy to use Bridge FetchQuotes#29157
joaosantos15 wants to merge 3 commits into
mainfrom
TSA-426-quickbuy-fetchquotes-partial

Conversation

@joaosantos15
Copy link
Copy Markdown
Contributor

Description

Refactor Quickbuy to use fetchQuotes instead of going through the Swaps/Bridge controller.

Changelog

CHANGELOG entry: no-changelog

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-social-ai Social & AI team label Apr 22, 2026
@github-actions github-actions Bot added size-XL and removed size-L labels Apr 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - draft PR

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 22, 2026

@joaosantos15 joaosantos15 changed the title Tsa 426 quickbuy fetchquotes partial chore: TSA-426. Refactor quickbuy to use Bridge FetchQuotes Apr 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
12 value mismatches detected (expected — fixture represents an existing user).
View details

* QuickBuy) populate this so the balance check still accounts for gas.
*/
quoteOverride?:
| (QuoteResponse & L1GasFees & NonEvmFees & QuoteMetadata)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be a better typing here

@joaosantos15
Copy link
Copy Markdown
Contributor Author

closed in favour of #29165

@github-actions github-actions Bot locked and limited conversation to collaborators Apr 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants