feat: explore page v2#29169
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| expect(elements[0]).toBeOnTheScreen(); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Test uses hardcoded text instead of locale keys
Low Severity
The new test selects elements using hardcoded English strings ('Now', 'Macro', 'RWAs', etc.) via getAllByText. The unit testing guidelines explicitly say to avoid selecting by hardcoded text content because it breaks when text changes (i18n, copy updates). The preferred approach is using locale keys like strings('trending.tabs.now') (which the component itself already uses) or testID props. Since the corresponding locale keys exist at trending.tabs.*, using strings() would make the test resilient to copy changes.
Triggered by project rule: Unit Testing Guidelines
Reviewed by Cursor Bugbot for commit 6abc407. Configure here.
AI PR Analysis🚫 Merge safe: false | 🟠 Risk: high
AI analysis did not complete. Manual review recommended. |
github-actions
Bot
added
risk:high
| * Sports tab: sport prediction markets (same carousel UX as the Now tab’s predictions, `sports` category). | ||
| */ | ||
| export const useSportsSections = (): (SectionConfig & { id: SectionId })[] => | ||
| useMemo(() => [SECTIONS_CONFIG.sports_predictions], []); |
There was a problem hiding this comment.
Prediction sections missing feature flag gate on two tabs
Medium Severity
useCryptoSections unconditionally pushes crypto_predictions and useSportsSections unconditionally includes sports_predictions, without checking isPredictEnabled. This is inconsistent with useMacroSections and useRwasSections, which both gate their prediction sections behind selectPredictEnabledFlag. When predictions are disabled, the Crypto and Sports tabs still mount prediction sections, triggering unnecessary API calls via usePredictMarketData and potentially displaying prediction content to users who shouldn't see it.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit fd00f64. Configure here.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c3a3165. Configure here.
| case 'perps': | ||
| case 'rwa_perps': | ||
| case 'macro_stocks_commodity_perps': | ||
| case 'crypto_perps': |
There was a problem hiding this comment.
New prediction section IDs missing from data transformation
Medium Severity
The sectionIdToCategory mapping correctly handles sports_predictions, crypto_predictions, and politics_predictions (lines 105–107), but the data transformation switch at line 313 only matches case 'predictions':. The new prediction section IDs are missing, so their data would remain an empty transformedData array. This is inconsistent with the perps and tokens branches, where all new variants (rwa_perps, macro_stocks_commodity_perps, crypto_perps, crypto_movers) were added to both switches.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit c3a3165. Configure here.
…obile into feat/explore-page-v2
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #29169 +/- ##
==========================================
- Coverage 82.35% 82.28% -0.07%
==========================================
Files 5139 5159 +20
Lines 136323 136829 +506
Branches 30711 30851 +140
==========================================
+ Hits 112266 112591 +325
- Misses 16430 16579 +149
- Partials 7627 7659 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - draft PR All E2E tests pre-selected. |
|
|
✅ E2E Fixture Validation — Schema is up to date |
3 participants
Description
Changelog
CHANGELOG entry:
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-3089
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Medium Risk
Moderate UI/logic refactor of the Explore feed and section configuration, plus new token sparkline fetching and navigation/analytics paths that could affect performance and routing if misconfigured.
Overview
Reworks the Explore (Trending) screen into a tabbed feed (
Now,Macro,RWAs,Crypto,Sports,Dapps) by replacing the single ScrollView + QuickActions with per-tab sectioned scroll panels.Expands and refactors
sections.configto support new section IDs (e.g.crypto_movers, multiple perps/predictions variants), adds reusable section renderers (TileSection,SectionPills,PillToggledCardSection), and changes token/perps presentation to tile cards and pill rows in the feed while keeping row-based rendering for search.Adds token sparkline support for trending token tiles via
useTrendingTokenTileSparklines(EVM fetches from the price API; non‑EVM delegates toMultichainAssetsRatesController), centralizesdownsampleinutil/sparklines, and updates omni-search/URL autocomplete mappings and tests/E2E selectors accordingly (including removing theexploreSectionsOrderfeature flag and QuickActions selectors).Reviewed by Cursor Bugbot for commit dffe339. Bugbot is set up for automated code reviews on this repo. Configure here.