chore(runway): cherry-pick fix: MUSD-671 money hub missing analytics cp-7.74.0#29212
Merged
Merged
Conversation
…cp-7.74.0 (#29147) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until this PR meets the canonical Definition of Ready For Review in `docs/readme/ready-for-review.md`. In short: the template must be materially complete (not just section titles present), all status checks must be currently passing, and the only expected follow-up commits must be reviewer-driven. --> ## **Description** Fixes incorrect and adds missing events for the Money hub experience. Also fixes incorrect navigation to mainnet mUSD asset details screen for `CashGetMusdEmptyState` and stale education screen not being popped-off of navigation stack for first-time users. ## Added Events (were missing) | Event Name | Trigger | |---|---| | `Money Hub Screen Viewed` | Fires once when the Money Hub screen mounts | | `Money Hub Token Row Convert Clicked` | User taps the "Max" button or the edit (pencil) icon on a token row in the Money Hub | | `Money Hub Convert Button Clicked` | User taps the "Convert" CTA button at the bottom of the Money Hub | | `Money Hub Learn More Pressed` | User taps "Learn more" in the Money Hub, opens mUSD learn more URL | | `Money Hub Swaps Button Clicked` | User taps the "Swap" button in the Money Hub empty state | | `Money Hub Buy Button Clicked` | User taps the "Buy" button in the Money Hub empty state | | `mUSD Bonus Learn More Pressed` | User taps "Learn more" inside the bonus claim tooltip in `AssetOverviewClaimBonus` | ## Updated Events (were incorrect) | Event Name | Change | |---|---| | `Tooltip Opened` | `location` is now prop-driven instead of hardcoded to `'asset_overview'`. | | `mUSD Bonus Terms of Use Pressed` | `location` changed from `'asset_overview_claimable_bonus_tooltip'` to `'bonus_claim_tooltip'`.| | `mUSD Claim Bonus Button Clicked` | `location` is now prop-driven (`'asset_overview'` or `'money_hub'`). | | `mUSD Claim Bonus CTA Displayed` | | | `Swap Button Clicked` | Added `'Money Hub'` as a new `location` source via `SwapBridgeNavigationLocation.MoneyHub`. | | `mUSD Fullscreen Announcement Button Clicked` | Added `'money_hub'` as a possible `redirects_to` value when the education screen is accessed via the Money Hub gate. | <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: fixes incorrect and adds missing events for the Money hub experience. ## **Related issues** Fixes: [MUSD-671: mUSD Money Hub: Missing & Incorrect Analytics Events (Tracking Gaps)](https://consensyssoftware.atlassian.net/browse/MUSD-671) ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> N/A ### **After** <!-- [screenshots/recordings] --> N/A ## **Pre-merge author checklist** <!-- Every checklist item must be consciously assessed before marking this PR as "Ready for review". A checked box means you deliberately considered that responsibility, not that you literally performed every action listed. Unchecked boxes are ambiguous: they are not an implicit "N/A" and they are not a silent "skip". See `docs/readme/ready-for-review.md` for the full checklist semantics. --> - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [ ] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [ ] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [ ] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** <!-- Reviewer checklist items follow the same semantics as the author checklist: an unchecked box is ambiguous, a checked box means the reviewer consciously assessed that responsibility. See `docs/readme/ready-for-review.md`. --> - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Medium risk because it changes navigation flows around the Cash/Money Hub education gate (including popping screens) and adds multiple new analytics events/parameters that could misfire or regress routing if incorrect. > > **Overview** > Adds a new `MONEY_EVENTS_CONSTANTS` module and expands MetaMetrics with **Money Hub** + **mUSD bonus Learn More** events, then instruments `CashTokensFullView` to fire screen/CTA/row-convert/learn-more tracking (including token/network context and highest-balance token on view). > > Refactors the Cash section entry points to use a shared `useCashNavigation` education gate that routes to Money Home or `CashTokensFullView` and passes a `returnTo` target through `EarnMusdConversionEducationView`; the education screen now **pops itself before navigating** to `returnTo` to avoid stale flashes and tracks `redirects_to` as `money_hub`. > > Updates `AssetOverviewClaimBonus` analytics to be *location-driven* (new `location` prop, forwarded into `useMerklBonusClaim`), renames the tooltip location to `BONUS_CLAIM_TOOLTIP`, and adds tracking for the tooltip’s **Learn more** link; adds/updates tests and introduces stable test IDs for `CashTokensFullView` buttons. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit b5bc75a. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - PR targets a release branch (release/*) All E2E tests pre-selected. |
Matt561
approved these changes
Apr 22, 2026
|
Contributor
|
✅ E2E Fixture Validation — Schema is up to date |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Fixes incorrect and adds missing events for the Money hub experience.
Also fixes incorrect navigation to mainnet mUSD asset details screen for
CashGetMusdEmptyStateand stale education screen not being popped-offof navigation stack for first-time users.
Added Events (were missing)
Money Hub Screen ViewedMoney Hub Token Row Convert ClickedMoney Hub Convert Button ClickedMoney Hub Learn More PressedMoney Hub Swaps Button ClickedMoney Hub Buy Button ClickedmUSD Bonus Learn More PressedAssetOverviewClaimBonusUpdated Events (were incorrect)
Tooltip Openedlocationis now prop-driven instead of hardcoded'asset_overview'.mUSD Bonus Terms of Use Pressedlocationchanged from'asset_overview_claimable_bonus_tooltip'to'bonus_claim_tooltip'.mUSD Claim Bonus Button Clickedlocationis now prop-driven'asset_overview'or'money_hub').mUSD Claim Bonus CTA DisplayedSwap Button Clicked'Money Hub'as a newlocationsourceSwapBridgeNavigationLocation.MoneyHub.mUSD Fullscreen Announcement Button Clicked'money_hub'asredirects_tovalue when the education screen is accessedChangelog
CHANGELOG entry: fixes incorrect and adds missing events for the Money
hub experience.
Related issues
Fixes: MUSD-671: mUSD Money Hub: Missing & Incorrect Analytics Events
(Tracking
Gaps)
Manual testing steps
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Performance checks (if applicable)
SRPs
to import wallets with many accounts and tokens
performance metrics
trace()for usage andaddTokenfor an example
For performance guidelines and tooling, see the Performance
Guide.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Medium Risk
Medium risk because it changes navigation flows around the Cash/Money
Hub education gate (including popping screens) and adds multiple new
analytics events/parameters that could misfire or regress routing if
incorrect.
Overview
Adds a new
MONEY_EVENTS_CONSTANTSmodule and expands MetaMetricswith Money Hub + mUSD bonus Learn More events, then instruments
CashTokensFullViewto fire screen/CTA/row-convert/learn-more tracking(including token/network context and highest-balance token on view).
Refactors the Cash section entry points to use a shared
useCashNavigationeducation gate that routes to Money Home orCashTokensFullViewand passes areturnTotarget throughEarnMusdConversionEducationView; the education screen now popsitself before navigating to
returnToto avoid stale flashes andtracks
redirects_toasmoney_hub.Updates
AssetOverviewClaimBonusanalytics to be location-driven(new
locationprop, forwarded intouseMerklBonusClaim), renames thetooltip location to
BONUS_CLAIM_TOOLTIP, and adds tracking for thetooltip’s Learn more link; adds/updates tests and introduces stable
test IDs for
CashTokensFullViewbuttons.Reviewed by Cursor Bugbot for commit
b5bc75a. Bugbot is set up for automated
code reviews on this repo. Configure
here.