Skip to content

ci: remove legacy Runway per-platform workflows (phase 2 cleanup)#29298

Merged
weitingsun merged 6 commits into
mainfrom
wsun/remove-old-runway-ota-and-native-build-combined-workflows
May 6, 2026
Merged

ci: remove legacy Runway per-platform workflows (phase 2 cleanup)#29298
weitingsun merged 6 commits into
mainfrom
wsun/remove-old-runway-ota-and-native-build-combined-workflows

Conversation

@weitingsun
Copy link
Copy Markdown
Contributor

@weitingsun weitingsun commented Apr 24, 2026

Description

Phase 2 cleanup of the Runway workflow split. Removes the legacy per-platform Runway entry workflows now that Runway has been flipped to dispatch the combined OTA-only and build-only workflows introduced in phase 1, and release/7.73.x / release/7.74.x are no longer actively maintained.

Context

Phase 1 (previous PR) added 5 new workflow files without touching anything existing:

  • runway-ota-resolve-context.yml
  • runway-production-builds.yml
  • runway-rc-builds.yml
  • runway-ota-production.yml
  • runway-ota-rc.yml

That PR intentionally deferred the cleanup so Runway could keep dispatching the old per-platform workflow names against release/7.73.x and release/7.74.x (which cannot receive cherry-picks).

What this PR does

  • Deletes the 4 legacy per-platform Runway entry workflows:
    • runway-ios-production-workflow.yml
    • runway-android-production-workflow.yml
    • runway-ios-rc-workflow.yml
    • runway-android-rc-workflow.yml
  • Renames runway-ota-build-core.ymlauto-rc-ota-build-core.yml to reflect that its only remaining caller is build-rc-auto.yml (auto-RC on push), not Runway.
  • Refactors the renamed core to call the reusable runway-ota-resolve-context.yml from phase 1 instead of keeping the decide + resolve-pr logic inline. Behaviour is identical; the logic is now shared with the OTA-only Runway workflows.
  • Updates build-rc-auto.yml uses: paths (two call sites) and the header comment to point at the renamed core.

What this PR does NOT change

  • No behaviour change for build-rc-auto.yml — same OTA-vs-build auto-detection, same parallel platform dispatch, same Slack notification.
  • No behaviour change for the 4 phase-1 Runway workflows.

Precondition for merge

Before merging this PR, verify that:

  1. Runway has been reconfigured to dispatch the 4 new workflow names (runway-production-builds.yml, runway-rc-builds.yml, runway-ota-production.yml, runway-ota-rc.yml).
  2. release/7.73.x and release/7.74.x are no longer being hotfixed via Runway dispatch (they can still receive direct pushes — build-rc-auto.yml on those branches uses the files present on that ref, which still include the legacy core until those branches are fully retired).

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Moderate risk because it changes GitHub Actions workflow entry points and reusable workflow wiring for OTA-vs-build detection, which could break release/RC automation if references or outputs diverge.

Overview
Refactors the auto-RC release flow by replacing the legacy reusable runway-ota-build-core.yml with a new auto-rc-ota-build-core.yml that delegates OTA bump/PR resolution to runway-ota-resolve-context.yml, while keeping the same OTA-vs-build branching behavior.

Cleans up CI by deleting the four per-platform Runway workflow_dispatch entry workflows (iOS/Android, RC/production) and updating build-rc-auto.yml to call the renamed core workflow for both iOS and Android RC triggers.

Reviewed by Cursor Bugbot for commit 54fc5ee. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-mobile-platform Mobile Platform team label Apr 24, 2026
@weitingsun weitingsun added the DO-NOT-MERGE Pull requests that should not be merged label Apr 24, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.13%. Comparing base (c728322) to head (a12aa9f).
⚠️ Report is 151 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #29298       +/-   ##
===========================================
- Coverage   82.25%   64.13%   -18.12%     
===========================================
  Files        5125     5130        +5     
  Lines      135641   135899      +258     
  Branches    30531    30597       +66     
===========================================
- Hits       111565    87165    -24400     
- Misses      16458    41989    +25531     
+ Partials     7618     6745      -873     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - draft PR

All E2E tests pre-selected.

View GitHub Actions results

@github-actions
Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
12 value mismatches detected (expected — fixture represents an existing user).
View details

weitingsun added 2 commits May 6, 2026 11:14
…rkflows' of github.com:MetaMask/metamask-mobile into wsun/remove-old-runway-ota-and-native-build-combined-workflows
@weitingsun weitingsun marked this pull request as ready for review May 6, 2026 18:16
@weitingsun weitingsun requested a review from a team as a code owner May 6, 2026 18:16
@weitingsun weitingsun enabled auto-merge May 6, 2026 18:16
@weitingsun weitingsun self-assigned this May 6, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 6, 2026

@weitingsun weitingsun removed the DO-NOT-MERGE Pull requests that should not be merged label May 6, 2026
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weitingsun weitingsun added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit d28ce2e May 6, 2026
74 of 75 checks passed
@weitingsun weitingsun deleted the wsun/remove-old-runway-ota-and-native-build-combined-workflows branch May 6, 2026 20:11
@github-actions github-actions Bot locked and limited conversation to collaborators May 6, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.77.0 Issue or pull request that will be included in release 7.77.0 label May 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.77.0 Issue or pull request that will be included in release 7.77.0 size-L team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants