chore(runway): cherry-pick fix(card): update feature flag listener on CardController

[runway-github]

• fix(card): update feature flag listener on CardController (fix(card): update feature flag listener on CardController #29350)

Description

This branch refreshes card home data and Baanx configuration when
remote card feature flags change, and fixes a race where a slow
unauthenticated fetchCardHomeData could overwrite state after
successful submitCredentials.

Feature flags

app/selectors/featureFlagController/card/index.ts:
exports defaultCardFeatureFlag and resolveCardFeatureFlag
(empty remote payload → defaults). selectCardFeatureFlag now uses
resolveCardFeatureFlag so the same resolution rules apply in Redux
selectors and Engine.

BaanxProvider / init

BaanxProvider.ts:
accepts optional getCardFeatureFlag (lazy) in addition to legacy
cardFeatureFlag. A private getter resolves cardFeatureFlag
on each read so URLs/constants track the latest remote flags without
recreating the provider.

card-controller/index.ts:
passes getCardFeatureFlag from
RemoteFeatureFlagController:getState +
resolveCardFeatureFlag into BaanxProvider.

CardController

• Subscribes to RemoteFeatureFlagController:stateChange with a
  selector that serializes remoteFeatureFlags.cardFeature so
  only meaningful card-flag updates run the handler.
• #handleCardFeatureFlagChange: if an EVM address is selected,
  invalidateFetch(), clears cardHomeData / sets
  cardHomeDataStatus to idle, then refetches card home data.
• #fetchCardHomeDataWithLogging: centralizes
  fetchCardHomeData + Logger.error for account switch,
  feature-flag refresh, submitCredentials, and
  validateAndRefreshSession.
• #triggerCardholderCheck (accounts API URL path): uses
  resolveCardFeatureFlag instead of ad-hoc casting.
• submitCredentials: sets cardHomeData to null and
  status idle, calls invalidateFetch(), then fetches—so
  in-flight unauthenticated responses cannot win over authenticated data.

Messenger / types

card-controller-messenger/index.ts:
allows event RemoteFeatureFlagController:stateChange.

• types.ts:
  CardControllerAllowedEvents includes
  RemoteFeatureFlagControllerStateChangeEvent.

Tests

CardController.test.ts:
subscription to remote feature-flag state; handler clears state and
refetches; drops in-flight unauthenticated card home data after successful auth.

BaanxProvider.test.ts:
getCardFeatureFlag read lazily during getOnChainAssets.

Changelog

CHANGELOG entry: Card — CardController listens for
RemoteFeatureFlagController:stateChange and refetches card home
data when cardFeature changes; BaanxProvider resolves card
feature flags lazily; shared resolveCardFeatureFlag;
submitCredentials invalidates in-flight fetches and resets card
home state to avoid stale unauthenticated data after login.

Related issues

Fixes: #29348

Manual testing steps

Feature: Card home and Baanx flags stay in sync with remote card feature flags

  Scenario: Remote card feature flag updates while card tab is open
    Given the user is on an EVM account with card session and card home loaded
    When remote `cardFeature` changes (e.g. rollout or config update)
    Then card home data is cleared to idle and refetched
    And Baanx-backed calls use the updated flag-derived config on subsequent requests

  Scenario: Login while an unauthenticated card home fetch is still in flight
    Given an unauthenticated card home fetch has not completed
    When the user completes submitCredentials successfully
    Then authenticated card home data wins and a late unauthenticated response does not overwrite it

  Scenario: Card feature flag change with no selected EVM address
    When RemoteFeatureFlagController emits a card-related change but no EVM address is selected
    Then the handler returns early without refetch errors

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor
  Docs and MetaMask Mobile
  Coding
  Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format
  if applicable
• I've applied the right labels on the PR (see labeling
  guidelines).
  Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
• Use these power-user
  SRPs
  to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production
  performance metrics
• See trace() for usage and
  addToken
  for an example

For performance guidelines and tooling, see the Performance
Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the
  app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described
  in the ticket it closes and includes the necessary testing evidence such
  as recordings and or screenshots.

---

Note

Medium Risk
Updates card state refresh triggers and fetch invalidation logic
around auth and feature-flag changes; risk is moderate due to new event
subscriptions and potential for extra network calls or missed updates if
selectors are wrong.

Overview
Card home data now refreshes when remote cardFeature flags
change. CardController subscribes to
RemoteFeatureFlagController:stateChange, clears cardHomeData/status
back to idle, invalidates any in-flight fetch, and refetches.

Fixes a race where slow unauthenticated fetches could overwrite
authenticated state. After successful submitCredentials, the
controller resets home data, bumps the fetch generation, and refetches
via a shared #fetchCardHomeDataWithLogging helper (also used by
account-switch and session refresh paths).

Feature-flag resolution and consumption were tightened. Adds
resolveCardFeatureFlag (and exports defaultCardFeatureFlag) to
normalize empty remote payloads to defaults; BaanxProvider can now
read flags lazily via a getCardFeatureFlag callback wired in
cardControllerInit, and the card-controller messenger/types allow the
new remote-flag stateChange event.

Tests add coverage for the new subscription behavior, the stale-fetch
drop after auth, and lazy flag reads in BaanxProvider.

^{Reviewed by Cursor Bugbot for commit
0d9863b. Bugbot is set up for automated
code reviews on this repo. Configure
here.}

[890ac4a](https://github.com/MetaMask/metamask-mobile/commit/890ac4ac4b372252149c8adac3bd9c93d29659b4)

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - PR targets a release branch (release/*)

All E2E tests pre-selected.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

✅ E2E Fixture Validation — Schema is up to date
12 value mismatches detected (expected — fixture represents an existing user).
View details