Skip to content

feat(walletconnect): add multichain routing and namespace approval for first non-EVM chain (Tron) #29428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Olivier-BB wants to merge 35 commits into
base: main
Choose a base branch
from

fix(walletconnect): finalize multichain review follow-ups and cleanup

72d4ea9
Select commit
Loading
Failed to load commit list.
Open

feat(walletconnect): add multichain routing and namespace approval for first non-EVM chain (Tron) #29428

fix(walletconnect): finalize multichain review follow-ups and cleanup
72d4ea9
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 6, 2026 in 1m 48s

Quality Gate failed

Failed conditions
60.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 22 in app/core/Permissions/index.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import of 'getPermittedEthChainIds'. 

See more on https://sonarcloud.io/project/issues?id=metamask-mobile&issues=AZ3Zdwdj384hUvdeVAyV&open=AZ3Zdwdj384hUvdeVAyV&pullRequest=29428

Check warning on line 359 in app/components/Views/MultichainAccounts/MultichainAccountConnect/MultichainAccountConnect.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=metamask-mobile&issues=AZ398EXu_xOelAgCQx-v&open=AZ398EXu_xOelAgCQx-v&pullRequest=29428

Check warning on line 426 in app/core/WalletConnect/multichain/tron/index.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the opposite operator (!==) instead. 

See more on https://sonarcloud.io/project/issues?id=metamask-mobile&issues=AZ3Zdwtk384hUvdeVAyb&open=AZ3Zdwtk384hUvdeVAyb&pullRequest=29428

Check warning on line 146 in app/core/WalletConnect/multichain/tron/index.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=metamask-mobile&issues=AZ3ZoEmDfDERzwLppCLp&open=AZ3ZoEmDfDERzwLppCLp&pullRequest=29428

Check warning on line 271 in app/core/WalletConnect/multichain/tron/index.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=metamask-mobile&issues=AZ3Zdwtk384hUvdeVAyX&open=AZ3Zdwtk384hUvdeVAyX&pullRequest=29428

Check warning on line 410 in app/core/WalletConnect/multichain/tron/index.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=metamask-mobile&issues=AZ3Zdwtk384hUvdeVAyZ&open=AZ3Zdwtk384hUvdeVAyZ&pullRequest=29428

Check failure on line 267 in app/core/WalletConnect/multichain/tron/index.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 32 to the 30 allowed. 

See more on https://sonarcloud.io/project/issues?id=metamask-mobile&issues=AZ3Zdwtk384hUvdeVAyW&open=AZ3Zdwtk384hUvdeVAyW&pullRequest=29428

Check warning on line 274 in app/core/WalletConnect/multichain/tron/index.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=metamask-mobile&issues=AZ3Zdwtk384hUvdeVAyY&open=AZ3Zdwtk384hUvdeVAyY&pullRequest=29428

Check warning on line 421 in app/core/WalletConnect/multichain/tron/index.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=metamask-mobile&issues=AZ3Zdwtk384hUvdeVAya&open=AZ3Zdwtk384hUvdeVAya&pullRequest=29428
View more details on SonarQubeCloud