Skip to content

fix: route DeFi empty-state CTA to Explore sites#29552

Merged
Prithpal-Sooriya merged 5 commits into
mainfrom
cursor/defi-explore-sites-5eb2
May 6, 2026
Merged

fix: route DeFi empty-state CTA to Explore sites#29552
Prithpal-Sooriya merged 5 commits into
mainfrom
cursor/defi-explore-sites-5eb2

Conversation

@Prithpal-Sooriya
Copy link
Copy Markdown
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Apr 30, 2026

Description

This change updates the DeFi empty-state Explore DeFi CTA behavior so it no longer opens the external MetaMask Portfolio explore tokens URL in the in-app browser.

Instead, pressing the CTA now navigates users to the in-app Explore flow and opens the Explore Sites section (TrendingView -> SitesFullView), matching the requested product direction and avoiding the blank page issue.

Changelog

CHANGELOG entry: Fixed the DeFi empty-state Explore button to open the in-app Explore sites screen instead of an external portfolio page.

Related issues

Fixes: #29471 https://consensyssoftware.atlassian.net/browse/ASSETS-3133

Manual testing steps

Feature: DeFi empty-state Explore CTA navigation

  Scenario: user opens Explore from empty DeFi tab
    Given the user is on the DeFi tab with no open positions
    When user taps the "Explore DeFi" button
    Then the app navigates to the Explore Sites screen
    And the app does not open portfolio.metamask.io/explore/tokens

Screenshots/Recordings

Before

N/A

After

https://www.loom.com/share/04b68f115a2c44a190bd7049b5ee323e

https://www.loom.com/share/88e42d07ee06480a90abde1d4771add2

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
  • I've tested with a power user scenario
  • I've instrumented key operations with Sentry traces for production performance metrics

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Open in Web Open in Cursor 

Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Prithpal-Sooriya Prithpal-Sooriya marked this pull request as ready for review May 6, 2026 15:35
@Prithpal-Sooriya Prithpal-Sooriya enabled auto-merge May 6, 2026 15:42
Copy link
Copy Markdown
Contributor Author

@Prithpal-Sooriya Prithpal-Sooriya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Prithpal-Sooriya
Copy link
Copy Markdown
Contributor Author

Prithpal-Sooriya commented May 6, 2026

👍🏾

@Prithpal-Sooriya Prithpal-Sooriya added the skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run label May 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 6, 2026

@Prithpal-Sooriya Prithpal-Sooriya added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit 88b007a May 6, 2026
207 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the cursor/defi-explore-sites-5eb2 branch May 6, 2026 19:39
@github-actions github-actions Bot locked and limited conversation to collaborators May 6, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.77.0 Issue or pull request that will be included in release 7.77.0 label May 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.77.0 Issue or pull request that will be included in release 7.77.0 size-S skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: DeFi: Clicking on Explore DeFi button leads to blank page

3 participants