Skip to content

test: mock accounts v4 transactions endpoint#29569

Merged
n3ps merged 1 commit into
mainfrom
n3ps/split-mock-server-e2e-e868
Apr 30, 2026
Merged

test: mock accounts v4 transactions endpoint#29569
n3ps merged 1 commit into
mainfrom
n3ps/split-mock-server-e2e-e868

Conversation

@n3ps
Copy link
Copy Markdown
Contributor

@n3ps n3ps commented Apr 30, 2026

Description

Registers a mock empty Accounts API v4 transactions response for testing.

Part of breaking down the Activity transactions PR into smaller chunks.

Changelog

CHANGELOG entry: null

Related issues

Refs: #29536

Manual testing steps

N/A - test infrastructure mock-only change.

Screenshots/Recordings

N/A - no user-facing UI changes.

Before

N/A

After

N/A

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • N/A - mock-only change.
  • I've tested with a power user scenario
    • N/A - mock-only change.
  • I've instrumented key operations with Sentry traces for production performance metrics
    • N/A - mock-only change.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Open in Web Open in Cursor 

Co-authored-by: Francis Nepomuceno <n3ps@users.noreply.github.com>
@n3ps n3ps requested a review from a team as a code owner April 30, 2026 14:48
@cursor
Copy link
Copy Markdown
Contributor

cursor Bot commented Apr 30, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@metamaskbotv2 metamaskbotv2 Bot added the team-core-extension-ux Core Extension UX team label Apr 30, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeSwap, SmokeStake, SmokeWalletPlatform, SmokeMoney, SmokePerps, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, SmokeBrowser, SmokeSnaps
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 82%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes modify the global E2E mock server infrastructure (MockServerE2E.ts and mockHelpers.ts), which is used by ALL E2E tests via FixtureHelper.ts. Specifically:

  1. A new global default mock is added for the Accounts API v4 transactions endpoint (/v4/multiaccount/transactions), returning an empty response by default.
  2. This mock is registered globally during MockServerE2E setup, meaning it applies to every single E2E test run without per-test configuration.

Since MockServerE2E is the central mock server used by all E2E tests, any regression in this infrastructure could break tests across all suites. The change itself is low-risk (adding a defensive empty mock to prevent unmocked network calls), but because it's global infrastructure, it warrants broad validation across all test tags to ensure:

  • No existing test that previously relied on the v4 transactions endpoint being unhandled (or proxied) is now broken by the empty mock response
  • The mock server still initializes correctly with the new mock registered
  • No test that explicitly mocks this endpoint is now conflicting with the global default

All E2E test tags are selected as a conservative approach given the global nature of this infrastructure change.

Performance Test Selection:
These changes are purely in the E2E test infrastructure (mock server setup). They do not affect any app code, UI rendering, data loading, state management, or any other aspect that would impact app performance. No performance tests are needed.

View GitHub Actions results

@n3ps n3ps enabled auto-merge April 30, 2026 14:52
@sonarqubecloud
Copy link
Copy Markdown

@n3ps n3ps added this pull request to the merge queue Apr 30, 2026
Merged via the queue into main with commit 60ef9e4 Apr 30, 2026
227 of 229 checks passed
@n3ps n3ps deleted the n3ps/split-mock-server-e2e-e868 branch April 30, 2026 16:28
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 30, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.76.0 Issue or pull request that will be included in release 7.76.0 label Apr 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.76.0 Issue or pull request that will be included in release 7.76.0 size-S team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants