feat: update usage of withKeyring to withKeyringV2 for EVM operations.

[hmalik88]

Description

Updates usage of withKeyring to withKeyringV2.

Note: Instances where withKeyring was not updated is considered to be dead code and will be removed in a follow up PR.

Changelog

CHANGELOG entry: null

Related issues

N/A

Manual testing steps

1. Build from this branch.
2. Ensure account ux is not affected (creating accounts, importing, using hardware wallets)

Screenshots/Recordings

N/A

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Medium Risk
Updates the keyring access method used when importing/restoring mnemonics, which can impact account selection/address retrieval during onboarding and seedless flows. Limited scope but touches wallet import/authentication paths where regressions would be user-visible.

Overview
Switches mnemonic import flows to use KeyringController.withKeyringV2 when retrieving the first account address after creating a multichain wallet (in actions/multiSrp.importNewSecretRecoveryPhrase and Authentication.importSeedlessMnemonicToVault).

Removes the unused createNewSecretRecoveryPhrase action and its associated unit tests, and updates the multiSrp tests to mock withKeyringV2 accordingly.

^{Reviewed by Cursor Bugbot for commit 2e9b628. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 2e9b628. Configure here.}

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeWalletPlatform, SmokeAccounts, SmokeIdentity, SmokeSeedlessOnboarding
• Selected Performance tags: None (no tests recommended)
• Risk Level: medium
• AI Confidence: 88%

click to see 🤖 AI reasoning details

E2E Test Selection:
The changes involve two key modifications:

1. app/actions/multiSrp/index.ts: Migrates importNewSecretRecoveryPhrase from KeyringController.withKeyring() to withKeyringV2(), which returns account objects {address} instead of plain address strings. All references updated from newAccountAddress (string) to newAccount.address. Also removes createNewSecretRecoveryPhrase function entirely (confirmed no remaining callers via grep).

2. app/core/Authentication/Authentication.ts: Same withKeyring → withKeyringV2 migration in the seedless onboarding SRP import path.

Impact areas:

• SmokeWalletPlatform: Multi-SRP wallet architecture is directly affected - importing additional Secret Recovery Phrases uses importNewSecretRecoveryPhrase, which is the core changed function. The ImportNewSecretRecoveryPhrase view component imports this function.
• SmokeAccounts: Account management flows (creating accounts under different SRPs, account switching) are affected by the multi-SRP changes. Per tag description, when multi-SRP architecture changes, SmokeAccounts should be selected.
• SmokeIdentity: Multi-SRP account synchronization is affected. Per tag description, when multi-SRP flows change, SmokeIdentity should be selected.
• SmokeSeedlessOnboarding: Authentication.ts changes directly affect the seedless onboarding SRP import flow (importSeedlessOnboardingSrp method uses withKeyringV2). The SeedlessOnboardingController integration path is modified.

The removal of createNewSecretRecoveryPhrase is a breaking change if any callers existed, but grep confirmed no remaining callers. The withKeyringV2 API change is a behavioral change that could affect account address resolution in error recovery paths.

Performance Test Selection:
The changes are focused on API migration (withKeyring → withKeyringV2) and function removal in multi-SRP flows. These are correctness/behavioral changes, not performance-sensitive changes. No UI rendering, list components, data loading patterns, or app initialization paths are modified in ways that would impact performance metrics.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[gantunesr]

looks good. We should do a quick sanity check

[hmalik88]

looks good. We should do a quick sanity check

Tested the flows, everything works