Skip to content

feat: MUSD-740, MUSD-746 — MetaMask Card section polish #29646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kureev merged 6 commits into from
May 6, 2026
+10 −7
Merged

feat: MUSD-740, MUSD-746 — MetaMask Card section polish #29646

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
eff546f
feat(MUSD-740, MUSD-746): polish MetaMask Card section
Kureev May 4, 2026
4251e17
Merge branch 'main' into kureev/MUSD-740-746-metamask-card-polish
Kureev May 5, 2026
0df732b
chore(deps): restore axios ^1.15.1 resolution to clear audit advisories
Kureev May 5, 2026
ba007a8
fix(MUSD-746): pass cashback string directly to Tag children for prop…
Kureev May 5, 2026
a0a2e2e
chore(MUSD-746): update Tag copy from "N% cashback" to "N% mUSD back"
Kureev May 6, 2026
8b2297f
Merge branch 'main' into kureev/MUSD-740-746-metamask-card-polish
Kureev May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/components/UI/Money/components/MoneyMetaMaskCard/MoneyMetaMaskCard.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ const styles = StyleSheet.create({
width: 104,
height: 66,
},
linkCardImage: {
width: 152,
height: 96,
},
});

export default styles;
25 changes: 15 additions & 10 deletions app/components/UI/Money/components/MoneyMetaMaskCard/MoneyMetaMaskCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ import {
IconColor,
IconName,
IconSize,
Tag,
TagSeverity,
Text,
TextColor,
TextVariant,
Expand Down Expand Up @@ -66,15 +68,17 @@ const CardRow = ({
<Text variant={TextVariant.BodyMd} fontWeight={FontWeight.Medium}>
{cardName}
</Text>
<Text
variant={TextVariant.BodySm}
fontWeight={FontWeight.Regular}
color={TextColor.SuccessDefault}
>
{strings('money.metamask_card.cashback', {
percentage: cashbackPercentage,
})}
</Text>
<Tag severity={TagSeverity.Success}>
<Text
variant={TextVariant.BodySm}
fontWeight={FontWeight.Medium}
color={TextColor.SuccessDefault}
>
{strings('money.metamask_card.cashback', {
percentage: cashbackPercentage,
})}
</Text>
</Tag>
Comment thread
cursor[bot] marked this conversation as resolved.
</Box>
</Box>
<Button
Expand Down Expand Up @@ -127,12 +131,13 @@ const LinkContent = ({
</Text>
<Box
flexDirection={BoxFlexDirection.Row}
alignItems={BoxAlignItems.Center}
twClassName="gap-4"
testID={MoneyMetaMaskCardTestIds.LINK_CONTAINER}
>
<Image
source={mmCardMetal}
style={styles.cardImage}
style={styles.linkCardImage}
testID={MoneyMetaMaskCardTestIds.LINK_CARD_IMAGE}
/>
<Box twClassName="gap-2 flex-1 justify-center">
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@
"@unrs/resolver-binding-wasm32-wasi": "npm:npm-empty-package@1.0.0",
"d3-color": "3.1.0",
"napi-postinstall": "npm:npm-empty-package@1.0.0",
"axios": "^1.15.0",
"axios": "^1.15.1",
Copy link
Copy Markdown
Contributor

@Jwhiles Jwhiles May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kureev why are we bumping axios?

Copy link
Copy Markdown
Contributor Author

@Kureev Kureev May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, that was a no-op vs current main. I merged main in and it went away

"lodash": "4.18.1",
"redux-persist-filesystem-storage/react-native-blob-util": "^0.19.9",
"@ethersproject/providers/ws": "^7.5.10",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22725,14 +22725,14 @@ __metadata:
languageName: node
linkType: hard

"axios@npm:^1.15.0":
version: 1.15.0
resolution: "axios@npm:1.15.0"
"axios@npm:^1.15.1":
version: 1.15.2
resolution: "axios@npm:1.15.2"
dependencies:
follow-redirects: "npm:^1.15.11"
form-data: "npm:^4.0.5"
proxy-from-env: "npm:^2.1.0"
checksum: 10/d39a2c0ebc7ff4739401b282e726cc2673377949d6c46d60eb619458f8d7a2f7eadbcada7097f4dbc7d5c59abb4d3bf6fac33d474412bc3415d3f5aa7ed45530
checksum: 10/eebbd8cb777316d4252cd994a06ec9fb956ef519214a62dab6c5443ae8b753b5116e9a770502316789e6cdef1101e6aae53b6936d6a3791b2d66d75f4d7d2462
languageName: node
linkType: hard

Expand Down
Loading