Skip to content

feat: add TabsIcon component family with icon tabs, scroll overflow detection, and collapse animation #29684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vinnyhoward merged 10 commits into from
May 6, 2026

fix: remove changes to tabs

ffa57ba
Select commit
Loading
Failed to load commit list.
Merged

feat: add TabsIcon component family with icon tabs, scroll overflow detection, and collapse animation #29684

fix: remove changes to tabs
ffa57ba
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 6, 2026 in 1m 44s

Quality Gate failed

Failed conditions
20.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 124 in app/component-library/components-temp/Tabs/TabsIconTab/TabsIconTab.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=metamask-mobile&issues=AZ30ts74cfeLMCCGsLWd&open=AZ30ts74cfeLMCCGsLWd&pullRequest=29684

Check warning on line 109 in app/component-library/components-temp/Tabs/TabsIconTab/TabsIconTab.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=metamask-mobile&issues=AZ30ts74cfeLMCCGsLWc&open=AZ30ts74cfeLMCCGsLWc&pullRequest=29684

Check warning on line 8 in app/component-library/components-temp/Tabs/TabsIconBar/TabsIconBar.types.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=metamask-mobile&issues=AZ30tssZcfeLMCCGsLWa&open=AZ30tssZcfeLMCCGsLWa&pullRequest=29684

Check warning on line 101 in app/component-library/components-temp/Tabs/TabsIconTab/TabsIconTab.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'Icon' is deprecated. 

See more on https://sonarcloud.io/project/issues?id=metamask-mobile&issues=AZ30ts74cfeLMCCGsLWb&open=AZ30ts74cfeLMCCGsLWb&pullRequest=29684
View more details on SonarQubeCloud