feat: batch sell token select#29690
Merged
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
44b8a5b to
5d2232f
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
25d540c to
0d52e36
Compare
Prithpal-Sooriya
previously approved these changes
May 7, 2026
e2f836c
d5df801 to
e2f836c
Compare
GeorgeGkas
previously approved these changes
May 8, 2026
…enSelect to use it
e5ba722 to
b5fb119
Compare
Prithpal-Sooriya
previously approved these changes
May 12, 2026
weitingsun
reviewed
May 12, 2026
d095c9a
Contributor
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Performance Test Selection: |
weitingsun
approved these changes
May 12, 2026
Prithpal-Sooriya
approved these changes
May 12, 2026
GeorgeGkas
approved these changes
May 12, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Adds the Batch Sell entry point and token selection flow for Unified Swaps. Users can select up to five same-network, non-zero-balance source tokens, excluding configured destination stablecoins, then hand them off to the quote flow.
This also adds the single-token high-rate alert path, Batch Sell Redux handoff state, network/value sorting, wallet-style token row price data, empty state handling, and focused unit coverage for the new flow.
This is hidden behind the env var
MM_BATCH_SELL_ENABLED.Changelog
CHANGELOG entry: Added Batch Sell token selection for selling up to five same-network tokens.
Related issues
Refs: SWAPS-4437
Manual testing steps
Screenshots/Recordings
Before
N/A - not captured in this generated draft.
After
Screen.Recording.2026-05-06.at.6.12.55.PM.mov
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Medium Risk
Adds a new Batch Sell entry point, navigation routes, and Redux handoff state, plus modifies shared token list UI (
TokenSelectorItem) and token-balance filtering; regressions could affect token selection display/behavior and bridge/swaps navigation.Overview
Introduces a new Batch Sell token selection screen in Bridge, allowing users to pick up to
5same-network tokens (filtered to supported chains, non-zero balances, and excluding configured destination stablecoins), with network pills, balance sort toggling, and an empty state that links to Explore tokens.Adds a single-token high-rate alert bottom sheet (
HighRateAlertModal) that redirects users to the standard swaps flow, and wires multi-token selections to the quote flow via new bridge-slice state (batchSellSourceTokens) and selectors.Extends
TokenSelectorItemwith optionalsecondaryRowContent, configurable balance text props, and flags to disable selected-row styling and network badges (used by the new Batch Sell rows showing fiat price + 24h % change), and gates the wallet entry point behindMM_BATCH_SELL_ENABLED/BATCH_SELL_ENABLED.Reviewed by Cursor Bugbot for commit d095c9a. Bugbot is set up for automated code reviews on this repo. Configure here.