refactor(bridge): use MMDS HeaderStandard#29700
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…' of https://github.com/MetaMask/metamask-mobile into refactor/headerstandard-titles-bridge
…to refactor/headerstandard-titles-bridge
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Performance Test Selection: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #29700 +/- ##
==========================================
+ Coverage 81.54% 81.86% +0.32%
==========================================
Files 5343 5434 +91
Lines 142128 144898 +2770
Branches 32411 33093 +682
==========================================
+ Hits 115899 118623 +2724
+ Misses 18299 18166 -133
- Partials 7930 8109 +179 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|



Description
Bridge Default and Custom slippage bottom sheets still used
HeaderCompactStandardfromcomponent-library. This migrates both toHeaderStandardfrom@metamask/design-system-react-nativeso slippage UI follows the same header pattern as the rest of the app and reduces reliance on the temporary header component.Changelog
CHANGELOG entry: null
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/DSYS-697
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
Low risk UI refactor limited to swapping header components and updating accessibility labels/translations; behavior changes should be confined to close button props and related tests.
Overview
Bridge slippage bottom sheets (default and custom) now use MMDS
HeaderStandardinstead of the temporaryHeaderCompactStandard, wiringonClosethrough the new header API.Adds a localized
bridge.closestring and updates modal tests to assert the header close button viaaccessibilityLabelfrom i18n rather than a hardcoded "Close" mock.Reviewed by Cursor Bugbot for commit 566ed03. Bugbot is set up for automated code reviews on this repo. Configure here.