Skip to content

ci: test play store validation workflow#29755

Open
joaoloureirop wants to merge 12 commits into
mainfrom
feat/android-manifest-validation
Open

ci: test play store validation workflow#29755
joaoloureirop wants to merge 12 commits into
mainfrom
feat/android-manifest-validation

Conversation

@joaoloureirop
Copy link
Copy Markdown
Contributor

@joaoloureirop joaoloureirop commented May 5, 2026

Description

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MCRM-73
https://consensyssoftware.atlassian.net/browse/MCWP-478

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@joaoloureirop joaoloureirop changed the title citest play store validation workflow ci: test play store validation workflow May 5, 2026
@metamaskbotv2 metamaskbotv2 Bot added the team-mobile-platform Mobile Platform team label May 5, 2026
@joaoloureirop joaoloureirop force-pushed the feat/android-manifest-validation branch 2 times, most recently from dd70ab3 to 1ee5e8c Compare May 13, 2026 15:46
@joaoloureirop joaoloureirop marked this pull request as ready for review May 13, 2026 16:15
@joaoloureirop joaoloureirop requested a review from a team as a code owner May 13, 2026 16:15
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 97%
click to see 🤖 AI reasoning details

E2E Test Selection:
All 9 changed files are exclusively Android CI/build infrastructure changes with zero impact on app runtime behavior:

  1. New GitHub Action (.github/actions/android-play-store-manifest-check/action.yml) for Play Store manifest validation - pure CI tooling
  2. build.yml additions for Play Store lint/bundle validation steps - CI workflow only
  3. slack-rc-notification.yml permissions + artifact download step - CI notification only
  4. android/app/build.gradle: adds lint baseline reference - build config only, no runtime change
  5. android/app/lint-baseline.xml: new lint baseline suppressing pre-existing issues - no runtime impact
  6. android/gradle.properties: adds byte-buddy Jetifier ignorelist - build tooling fix, no runtime behavior change
  7. android/gradle.properties.github: same byte-buddy fix for CI builds
  8. scripts/android-play-store-check-slack.mjs: new non-blocking CI check script
  9. scripts/slack-rc-notification.mjs: adds optional Play Store check report to Slack notifications

None of these changes touch app source code, React Native components, controllers, navigation, or any user-facing functionality. The changes are entirely confined to Android build tooling, CI workflows, and notification scripts. No E2E tests are needed to validate these changes.

Performance Test Selection:
All changes are CI/build infrastructure and Gradle configuration. No app source code, UI components, data loading, or runtime behavior is modified. Performance tests are not applicable.

View GitHub Actions results

@github-actions github-actions Bot added size-XL and removed size-L labels May 13, 2026
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant