fix(rewards): remove sign for rebalance events

[sophieqgu]

Description

https://consensyssoftware.atlassian.net/browse/RWDS-1264

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Low Risk
Low risk UI formatting change limited to OndoActivityRow display logic, with added test coverage; no business logic, persistence, or security-sensitive code impacted.

Overview
Updates Ondo campaign activity rows so REBALANCE entries display USD amounts without the leading + sign, while deposits/withdrawals/outflows continue to use signed USD formatting.

Adds a small helper (formatActivityUsd) to special-case rebalance values (returning — for null/non-numeric inputs) and extends the unit test suite to assert the new rebalance formatting behavior.

^{Reviewed by Cursor Bugbot for commit 0ea01cd. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: None (no tests recommended)
• Selected Performance tags: None (no tests recommended)
• Risk Level: low
• AI Confidence: 95%

click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are limited to two files in the Rewards/Campaigns UI component area:

1. OndoActivityRow.tsx: A small, focused bug fix that introduces a formatActivityUsd helper to handle REBALANCE activity entries differently — using formatUsd (no sign prefix) instead of formatSignedUsd (which adds '+' for positive values). The change only affects the display of USD amounts for REBALANCE-type activity entries in the Ondo campaign portfolio view.

2. OndoActivityRow.test.tsx: Adds a unit test to verify the new REBALANCE formatting behavior.

Why no E2E tags are needed:

• The change is purely a display/formatting fix in a narrow, isolated UI component (OndoActivityRow) within the Rewards/Campaigns feature
• The component is only consumed by OndoCampaignPortfolioView.tsx — no shared components, navigation, or core infrastructure are affected
• No available E2E test tags cover the Ondo/Rewards campaign portfolio activity view specifically
• The fix is well-covered by the added unit test
• No changes to controllers, state management, navigation, or any shared components that could cause regressions in other flows
• Risk of regression to other features is essentially zero

Performance Test Selection:
The change is a pure display formatting fix (string formatting logic for USD amounts in activity rows). There is no impact on rendering performance, data loading, state management, or any performance-sensitive code paths. No performance tests are warranted.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud