Skip to content

test: runs mm-connect tests on rc only for Samsung devices#29805

Merged
christopherferreira9 merged 1 commit into
mainfrom
cferreira/update-mm-connect-ci-runs
May 6, 2026
Merged

test: runs mm-connect tests on rc only for Samsung devices#29805
christopherferreira9 merged 1 commit into
mainfrom
cferreira/update-mm-connect-ci-runs

Conversation

@christopherferreira9
Copy link
Copy Markdown
Contributor

@christopherferreira9 christopherferreira9 commented May 6, 2026

Description

This PR makes the following changes to the MMConnect runs:

  • Only run on Samsung Devices -> reduces consumption on browserstack and keeps tests stable
  • Only run on rc environment

Changelog

CHANGELOG entry:

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMQA-1797

Manual testing steps

N/A

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Changes CI workflow conditions and device selection for MM-Connect runs, which could unintentionally reduce test coverage or skip runs if the matrix/filter is wrong. No production app code changes, but it affects release-signal reliability.

Overview
Updates the performance E2E GitHub workflow to scope Android MM-Connect runs more narrowly.

MM-Connect now uses a dedicated android_mm_connect_matrix filtered to Samsung devices, and both the MM-Connect job and the RN Playground APK upload step are gated to run only when build_variant is rc (skipping these steps for experimental builds).

Reviewed by Cursor Bugbot for commit 1fb6325. Bugbot is set up for automated code reviews on this repo. Configure here.

@christopherferreira9 christopherferreira9 requested a review from a team as a code owner May 6, 2026 15:30
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-qa QA team label May 6, 2026
@github-actions github-actions Bot added the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label May 6, 2026
@christopherferreira9 christopherferreira9 changed the title test: runs mmconnect tests on rc only for Samsung devices test: runs mm-connect tests on rc only for Samsung devices May 6, 2026
@github-actions github-actions Bot added the size-S label May 6, 2026
@christopherferreira9 christopherferreira9 added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed and removed pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. labels May 6, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 6, 2026

@christopherferreira9 christopherferreira9 added this pull request to the merge queue May 6, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 6, 2026
@christopherferreira9 christopherferreira9 added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit 3de0bcc May 6, 2026
115 of 146 checks passed
@christopherferreira9 christopherferreira9 deleted the cferreira/update-mm-connect-ci-runs branch May 6, 2026 17:03
@github-actions github-actions Bot locked and limited conversation to collaborators May 6, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.77.0 Issue or pull request that will be included in release 7.77.0 label May 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.77.0 Issue or pull request that will be included in release 7.77.0 size-S team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants