Skip to content

fix(rewards): localize campaign date #29808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sophieqgu merged 1 commit into from
May 6, 2026
+12 −23
Merged

fix(rewards): localize campaign date #29808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/components/UI/Rewards/components/Campaigns/CampaignTile.utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ jest.mock('@metamask/design-system-react-native', () => ({
}));

jest.mock('../../../../../../locales/i18n', () => ({
__esModule: true,
default: { locale: 'en-US' },
strings: jest.fn((key: string, params?: Record<string, string>) =>
params ? `${key}:${JSON.stringify(params)}` : key,
),
Expand Down
33 changes: 10 additions & 23 deletions app/components/UI/Rewards/components/Campaigns/CampaignTile.utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ import {
type CampaignDto,
type CampaignStatus,
} from '../../../../../core/Engine/controllers/rewards-controller/types';
import { strings } from '../../../../../../locales/i18n';
import I18n, { strings } from '../../../../../../locales/i18n';
import { getIntlDateTimeFormatter } from '../../../../../util/intl';

/**
* Set of campaign types that have full UI support (details view, opt-in, etc.)
Expand Down Expand Up @@ -53,32 +54,18 @@ export function getCampaignStatus(campaign: CampaignDto): CampaignStatus {
return 'complete';
}

const MONTHS = [
'January',
'February',
'March',
'April',
'May',
'June',
'July',
'August',
'September',
'October',
'November',
'December',
];

/**
* Formats a date for display in campaign tiles.
* Formats a date for display in campaign tiles (localized month and day).
*
* @param date - The date to format
* @returns Formatted date string (e.g., "March 15")
* @param locale - BCP 47 locale; defaults to the app locale
* @returns Formatted date string (e.g., "March 15" in en-US)
*/
function formatCampaignDate(date: Date): string {
const month = MONTHS[date.getMonth()];
const day = date.getDate();

return `${month} ${day}`;
function formatCampaignDate(date: Date, locale: string = I18n.locale): string {
return getIntlDateTimeFormatter(locale, {
month: 'long',
day: 'numeric',
}).format(date);
}

/**
Expand Down
Loading