fix(android): inject webview script at document start#29810
Closed
davidmurdoch wants to merge 1 commit into
Closed
fix(android): inject webview script at document start#29810davidmurdoch wants to merge 1 commit into
davidmurdoch wants to merge 1 commit into
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Author
|
I have read the CLA Document and I hereby sign the CLA |
Collaborator
Author
|
Replaced by #29821, which uses an upstream MetaMask branch so trusted CI can run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Patches
@metamask/react-native-webview@14.6.0on Android soinjectedJavaScriptBeforeContentLoadeduses AndroidXWebViewCompat.addDocumentStartJavaScriptwhenWebViewFeature.DOCUMENT_START_SCRIPTis supported.The patch registers the document-start script before
loadSource, refreshes the registration when relevant props change, preserves the existingevaluateJavascriptpath as the unsupported-device fallback, and keeps the default main-frame-only behavior with a small frame guard.Validation so far:
patch -d /tmp/rnw-mm-doc-start-verify -p4 --dry-run -i patches/@metamask+react-native-webview+14.6.0.patchyarn jest scripts/react-native-webview-document-start-patch.test.ts --runInBandcould not run locally because this checkout has nonode_modulesstate fileChangelog
CHANGELOG entry: null
Related issues
Fixes: N/A
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist