fix(Rewards): Ondo campaign text issues cp-7.76.0

[Montoya]

Description

This cleans up some unintentional text issues when displaying Ondo assets in the Rewards tab. This makes the Rewards tab match how Ondo assets are displayed elsewhere in the app.

Changelog

CHANGELOG entry: null

Related issues

Fixes: n/a

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Low Risk
Low risk UI/text-only changes in Rewards Ondo views plus removal of a now-unused formatting helper; primary risk is minor regressions in how token names/units are displayed and in i18n key usage.

Overview
Rewards Ondo screens now preserve backend-provided token display names (including the (Ondo Tokenized) suffix) instead of stripping/truncating branding via sanitizeOndoTokenName, and navigation to swaps passes the same unmodified name.

Ondo portfolio rows adjust layout to truncate long names and change the units subtext from a localized "{{units}} shares" string to a direct ${units} ${TOKEN_SYMBOL} format (uppercased), removing the position_units i18n key and associated tests.

^{Reviewed by Cursor Bugbot for commit 60550e0. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: None (no tests recommended)
• Selected Performance tags: None (no tests recommended)
• Risk Level: low
• AI Confidence: 90%

click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are confined to the Rewards/Ondo campaign feature area:

1. OndoCampaignRwaSelectorView.tsx: Removed sanitizeOndoTokenName import and usage - tokens now use backend-provided display names directly. Simplified handleAssetSelect to use asset.name directly instead of looking up raw token name.

2. OndoPortfolio.tsx: Removed sanitizeOndoTokenName usage, added layout improvements (flex-1, min-w-0, truncation for long names), changed position units display from localized strings('rewards.ondo_campaign_portfolio.position_units', ...) to inline ${units} ${symbol} format.

3. OndoPortfolio.utils.ts: Removed re-export of sanitizeOndoTokenName.

4. formatUtils.ts: Deleted the sanitizeOndoTokenName function entirely (confirmed no remaining usages in codebase).

5. Locale files (13 languages): Removed position_units key that was replaced with inline formatting.

Why no E2E tags are needed:

• No E2E tests exist for the Rewards/Ondo feature (confirmed by searching for 'Rewards', 'ondo', 'rwa' in e2e files - no matches found)
• The changes don't affect any shared components (navigation, modals, confirmations, browser, etc.)
• The Rewards navigator is part of MainNavigator but the Ondo-specific views are feature-isolated
• Changes are UI refinements (removing client-side name sanitization, layout improvements) with no impact on core wallet flows
• None of the available E2E test tags cover Rewards/Ondo campaign functionality

Performance Test Selection:
The changes are UI refinements to the Rewards/Ondo campaign feature - removing a string sanitization function and adjusting layout. These changes don't affect app startup, account/network lists, critical user flows (login, swap, send), or any performance-sensitive code paths. No performance tests are warranted.

View GitHub Actions results

[codecov-commenter]

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.42%. Comparing base (dba2c63) to head (60550e0).
⚠️ Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
...s/UI/Rewards/Views/OndoCampaignRwaSelectorView.tsx	80.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #29815      +/-   ##
==========================================
- Coverage   81.97%   81.42%   -0.55%     
==========================================
  Files        5302     5300       -2     
  Lines      140763   140725      -38     
  Branches    32047    32033      -14     
==========================================
- Hits       115391   114590     -801     
- Misses      17517    18295     +778     
+ Partials     7855     7840      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud