Skip to content

chore: remove unused ContractBox temp components#29816

Merged
georgewrmarshall merged 1 commit into
mainfrom
remove-contract-box-temp-components
May 6, 2026
Merged

chore: remove unused ContractBox temp components#29816
georgewrmarshall merged 1 commit into
mainfrom
remove-contract-box-temp-components

Conversation

@AndyMBridges
Copy link
Copy Markdown
Contributor

@AndyMBridges AndyMBridges commented May 6, 2026

Description

Removes the unused temporary ContractBox and ContractBoxBase components from app/component-library/components-temp/Contracts.

The prior audit found no production imports, and a follow-up reference search confirms no remaining references.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: temporary component cleanup

  Scenario: ContractBox temp components are removed
    Given the repository is on this branch
    When searching for ContractBox and ContractBoxBase references
    Then no app, test, or Storybook references are found

Screenshots/Recordings

N/A. Code cleanup only.

Before

N/A

After

N/A

Validation

  • rg -n "ContractBox|ContractBoxBase|CONTRACT_BOX|components-temp/Contracts" app tests .storybook --glob '!node_modules/**' returned no matches.
  • yarn lint:tsc was run and failed on existing unrelated type errors in confirmations, SocialLeaderboard tests, bridge messenger types, multichain assets rates messenger types, and test account utilities.

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
  • I've tested with a power user scenario
  • I've instrumented key operations with Sentry traces for production performance metrics

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@AndyMBridges AndyMBridges self-assigned this May 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-core-extension-ux Core Extension UX team label May 6, 2026
@AndyMBridges AndyMBridges marked this pull request as ready for review May 6, 2026 17:56
@AndyMBridges AndyMBridges requested a review from a team as a code owner May 6, 2026 17:56
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 98%
click to see 🤖 AI reasoning details

E2E Test Selection:
All 12 changed files are pure deletions of two unused UI components: ContractBox and ContractBoxBase from app/component-library/components-temp/Contracts/.

Key findings:

  1. All changes are file deletions — no new code was added, only removed.
  2. No consumers exist — grep searches for ContractBox, ContractBoxBase, and from.*ContractBox across all .tsx, .ts, and * files returned zero matches. These components were completely unused in the codebase.
  3. Dead code cleanup — this is a straightforward removal of orphaned component library files (component, styles, types, constants, tests, and index files for both ContractBox and ContractBoxBase).
  4. No impact on any user flows — since nothing imports these components, no E2E test scenarios can be affected by their removal.
  5. No performance impact — no rendering, state management, or data loading code was changed.

No E2E tests need to run for this change, and no performance tests are warranted.

Performance Test Selection:
Pure deletion of unused UI components with no consumers. No rendering, state management, or data loading code was changed. No performance impact possible.

View GitHub Actions results

@github-actions github-actions Bot added the size-M label May 6, 2026
Copy link
Copy Markdown
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 6, 2026

@georgewrmarshall georgewrmarshall added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit ba4c881 May 6, 2026
76 checks passed
@georgewrmarshall georgewrmarshall deleted the remove-contract-box-temp-components branch May 6, 2026 18:40
@github-actions github-actions Bot locked and limited conversation to collaborators May 6, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.77.0 Issue or pull request that will be included in release 7.77.0 label May 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.77.0 Issue or pull request that will be included in release 7.77.0 size-M team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants