Skip to content

chore: download artifact for expo dev builds from github action expo dev build#29891

Draft
tommasini wants to merge 2 commits into
mainfrom
chore/download-script-from-gh
Draft

chore: download artifact for expo dev builds from github action expo dev build#29891
tommasini wants to merge 2 commits into
mainfrom
chore/download-script-from-gh

Conversation

@tommasini
Copy link
Copy Markdown
Contributor

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-mobile-platform Mobile Platform team label May 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 98%
click to see 🤖 AI reasoning details

E2E Test Selection:
All 5 changed files are purely developer tooling scripts with no impact on app source code, E2E test infrastructure, or CI pipelines:

  1. package.json: Only 2 lines changed — renaming npm script aliases from install:ios:runway/install:android:runway to install:ios:gh/install:android:gh. No dependency changes, no build config changes, no test configuration changes.

  2. scripts/install-android-gh-expo-dev.sh (new) and scripts/install-ios-gh-expo-dev.sh (new): New local developer convenience scripts that download expo-dev builds from GitHub Actions artifacts instead of Runway's bucket API. These are only used by developers to install builds on local simulators/emulators.

  3. scripts/install-android-runway-app.sh (deleted) and scripts/install-ios-runway-app.sh (deleted): Old Runway-based install scripts being replaced.

These changes:

  • Do NOT affect any app source code, components, controllers, or navigation
  • Do NOT affect any E2E test files, test infrastructure, or CI workflows
  • Do NOT affect any build configurations (metro.config.js, babel.config.js, .detoxrc.js unchanged)
  • Are not invoked by any automated CI/CD E2E test pipeline
  • Only affect local developer workflows for manually installing builds

No E2E tests need to run for these purely infrastructural developer tooling changes.

Performance Test Selection:
No performance-relevant code was changed. These are purely developer convenience scripts for installing builds locally. No UI components, data loading, state management, or app initialization code was modified.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 8, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant