Skip to content

feat(card): wire Add Funds to unified ramp buy from card home#29925

Draft
amitabh94 wants to merge 2 commits into
mainfrom
feat/card-unified-buy-wiring
Draft

feat(card): wire Add Funds to unified ramp buy from card home#29925
amitabh94 wants to merge 2 commits into
mainfrom
feat/card-unified-buy-wiring

Conversation

@amitabh94
Copy link
Copy Markdown
Contributor

Description

Wires Card Add Funds to unified ramp buy via useRampNavigation / cardFundingTokenToRampIntent, with buyFlowOrigin: 'cardHome' for BuildQuote analytics. Adds cardHome to BuyFlowOrigin and handles Token not available modal navigation back to the Card tab using typed stack navigation (StackNavigationProp<ParamListBase>). Depends on PR 1 (feat/ramp-navigate-to-buy-foundation); this branch stacks that commit so it can merge after PR 1 or be rebased once PR 1 lands.

Follow-up (not in this PR): NativeFlow hoist, sell-only aggregator, and Deposit removal remain future phases when code exists.

Changelog

CHANGELOG entry: Improved Card Add Funds flow to use unified ramp buy routing when applicable.

Related issues

Fixes: N/A

Manual testing steps

Feature: Card Add Funds to unified buy

  Scenario: open unified buy from card add funds
    Given a wallet with Card home and ramps enabled
    When the user opens Add Funds on Card and chooses deposit/buy
    Then unified buy opens with the expected token context

  Scenario: token unavailable from card-originated buy
    Given the user started buy from card home
    When the token unavailable modal appears and the user changes token
    Then navigation returns to the Card home tab as expected

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

amitabh94 and others added 2 commits May 8, 2026 10:11
Co-authored-by: Cursor <cursoragent@cursor.com>
@amitabh94 amitabh94 self-assigned this May 8, 2026
@metamaskbotv2 metamaskbotv2 Bot added the team-money-movement issues related to Money Movement features label May 8, 2026
@github-actions github-actions Bot added the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label May 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the size-L label May 8, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 8, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. size-L team-money-movement issues related to Money Movement features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant