Skip to content

ci: pre-warm Namespace cache for unit/component-view test shards #30098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tommasini merged 14 commits into from
May 15, 2026
Merged

ci: pre-warm Namespace cache for unit/component-view test shards #30098

Changes from 5 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
49a07cb
reuse js deps in unit tests ci
tommasini May 13, 2026
b6c1920
Merge branch 'main' into ci/reuse-js-deps-ci
tommasini May 13, 2026
8b790cc
reuse setup-node-modules action
tommasini May 13, 2026
e976af6
ci: simplify prepare-ci-js-deps to use setup-node-modules unmodified
tommasini May 13, 2026
29627d5
Merge branch 'main' into ci/reuse-js-deps-ci
tommasini May 13, 2026
d19f532
permissions for prepare ci js deps
tommasini May 13, 2026
2794cba
reuse js deps
tommasini May 13, 2026
5765b44
not use gh cache
tommasini May 13, 2026
3f2ca41
update comments
tommasini May 13, 2026
a7b825a
adding gh artifacts for fallback to store js dependencies (compressed…
tommasini May 14, 2026
3370b72
if failure we fallback to normal install
tommasini May 14, 2026
7c8ed8d
always run yarn install on namespace
tommasini May 14, 2026
27c111f
restore original guard, while preserving the ci js deps fallback
tommasini May 14, 2026
d9e8501
merge main and solve conflicts
tommasini May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
120 changes: 48 additions & 72 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,39 +527,45 @@ jobs:
run: ${{ steps.download-actionlint.outputs.executable }} -color -config-file .github/actionlint.yaml
shell: bash

prepare-ci-js-deps:
name: Prepare CI JS dependencies
if: ${{ needs.get_requirements.outputs.skip_everything != 'true' }}
needs:
- get_requirements
uses: ./.github/workflows/setup-node-modules.yml
with:
artifact-name: ci-js-deps
artifact-retention-days: 1
runner_provider: ${{ inputs.runner_provider }}

unit-tests:
name: Unit tests (${{ matrix.shard }})
runs-on: ${{ inputs.runner_provider == 'namespace' && 'namespace-profile-metamask-ci-linux' || 'ubuntu-latest' }}
if: ${{ needs.get_requirements.outputs.skip_everything != 'true' }}
needs:
- get_requirements
- prepare-ci-js-deps
Comment thread
cursor[bot] marked this conversation as resolved.
strategy:
matrix:
shard: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
steps:
- uses: actions/checkout@v6
- name: Configure Namespace cache
if: ${{ inputs.runner_provider == 'namespace' }}
uses: namespacelabs/nscloud-cache-action@15799a6b54e5765f85b2aac25b3f0df43ed571c0 # v1
with:
path: |
~/.cache/yarn
.metamask
node_modules
.yarn/cache
- uses: actions/setup-node@v6
with:
node-version-file: '.nvmrc'
cache: ${{ inputs.runner_provider != 'namespace' && 'yarn' || '' }}
- name: Install Yarn dependencies with retry
uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 #v3.0.2
- name: Download node_modules artifact
uses: actions/download-artifact@v4
with:
timeout_minutes: 10
max_attempts: 3
retry_wait_seconds: 30
command: yarn install --immutable
- name: Clean state and following up dependencies installation
run: yarn setup:github-ci --node
name: ${{ needs.prepare-ci-js-deps.outputs.artifact-name }}
- name: Restore executable permissions
uses: ./.github/actions/restore-node-modules-permissions
- name: Verify downloaded artifacts
shell: bash
run: |
set -euo pipefail
test -d node_modules
test -f app/util/termsOfUse/termsOfUseContent.ts
Comment thread
cursor[bot] marked this conversation as resolved.
Outdated
- name: Prepare results directory
run: mkdir -p tests/results
# The "10" in this command is the total number of shards. It must be kept
Expand Down Expand Up @@ -594,42 +600,26 @@ jobs:
# threshold calculation is accurate.
merge-unit-and-component-view-tests:
runs-on: ${{ inputs.runner_provider == 'namespace' && 'namespace-profile-metamask-ci-linux' || 'ubuntu-latest' }}
needs: [unit-tests, component-view-tests]
needs: [prepare-ci-js-deps, unit-tests, component-view-tests]
if: ${{ !cancelled() && github.event_name != 'merge_group' }}
steps:
- uses: actions/checkout@v6
- name: Configure Namespace cache
if: ${{ inputs.runner_provider == 'namespace' }}
uses: namespacelabs/nscloud-cache-action@15799a6b54e5765f85b2aac25b3f0df43ed571c0 # v1
with:
path: |
~/.cache/yarn
.metamask
node_modules
.yarn/cache
- name: Restore node_modules cache
if: ${{ inputs.runner_provider != 'namespace' }}
id: cache-node-modules
uses: actions/cache@v4
with:
path: |
node_modules
.yarn/install-state.gz
key: ${{ runner.os }}-node-modules-${{ hashFiles('yarn.lock') }}
- uses: actions/setup-node@v6
with:
node-version-file: '.nvmrc'
cache: ${{ inputs.runner_provider != 'namespace' && 'yarn' || '' }}
- name: Install Yarn dependencies with retry
if: ${{ inputs.runner_provider == 'namespace' || steps.cache-node-modules.outputs.cache-hit != 'true' }}
uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 #v3.0.2
- name: Download node_modules artifact
uses: actions/download-artifact@v4
with:
timeout_minutes: 10
max_attempts: 3
retry_wait_seconds: 30
command: yarn install --immutable
- name: Clean state and following up dependencies installation
run: yarn setup:github-ci --node
name: ${{ needs.prepare-ci-js-deps.outputs.artifact-name }}
Comment thread
cursor[bot] marked this conversation as resolved.
Outdated
- name: Restore executable permissions
uses: ./.github/actions/restore-node-modules-permissions
- name: Verify downloaded artifacts
shell: bash
run: |
set -euo pipefail
test -d node_modules
test -f app/util/termsOfUse/termsOfUseContent.ts
- uses: actions/download-artifact@v4
with:
pattern: coverage-*
Expand Down Expand Up @@ -724,43 +714,28 @@ jobs:
if: ${{ needs.get_requirements.outputs.skip_everything != 'true' }}
needs:
- get_requirements
- prepare-ci-js-deps
strategy:
matrix:
shard: [1, 2]
steps:
- uses: actions/checkout@v6
- name: Configure Namespace cache
if: ${{ inputs.runner_provider == 'namespace' }}
uses: namespacelabs/nscloud-cache-action@15799a6b54e5765f85b2aac25b3f0df43ed571c0 # v1
with:
path: |
~/.cache/yarn
.metamask
node_modules
.yarn/cache
- name: Restore node_modules cache
if: ${{ inputs.runner_provider != 'namespace' }}
id: cache-node-modules
uses: actions/cache@v4
with:
path: |
node_modules
.yarn/install-state.gz
key: ${{ runner.os }}-node-modules-${{ hashFiles('yarn.lock') }}
- uses: actions/setup-node@v6
with:
node-version-file: '.nvmrc'
cache: ${{ inputs.runner_provider != 'namespace' && 'yarn' || '' }}
- name: Install Yarn dependencies with retry
if: ${{ inputs.runner_provider == 'namespace' || steps.cache-node-modules.outputs.cache-hit != 'true' }}
uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 #v3.0.2
- name: Download node_modules artifact
uses: actions/download-artifact@v4
with:
timeout_minutes: 10
max_attempts: 3
retry_wait_seconds: 30
command: yarn install --immutable
- name: Clean state and following up dependencies installation
run: yarn setup:github-ci --node
name: ${{ needs.prepare-ci-js-deps.outputs.artifact-name }}
- name: Restore executable permissions
uses: ./.github/actions/restore-node-modules-permissions
- name: Verify downloaded artifacts
shell: bash
run: |
set -euo pipefail
test -d node_modules
test -f app/util/termsOfUse/termsOfUseContent.ts
- name: Prepare results directory
run: mkdir -p tests/results
- run: |
Expand Down Expand Up @@ -1080,6 +1055,7 @@ jobs:
- unit-tests
- component-view-tests
- check-workflows
- prepare-ci-js-deps
- js-bundle-size-check
- sonar-cloud-quality-gate-status
- build-android-apks
Expand Down
Loading