-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: implement Pay With Perps section #30124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vinistevam
wants to merge
36
commits into
main
Choose a base branch
from
vs/pay-with-perps-section
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
fb2e0bc
feat: add PayWithBottomSheet component and related functionality
vinistevam db74f9f
refactor: remove useMMPayFiatConfig and related feature flag logic fr…
vinistevam 89b206f
Merge branch 'main' into vs/pay-with-bottom-sheet-skeleton
vinistevam a4da98f
refactor: update trailingElement type to ReactElement in PayWithRowCo…
vinistevam 6bb9ae7
Merge branch 'vs/pay-with-bottom-sheet-skeleton' of github.com:MetaMa…
vinistevam ff93b41
feat: implement pay with crypto section and related hooks, tests
vinistevam 7a79ece
fix ci
vinistevam b992716
refactor: remove useMMPayFiatConfig hook and related logic from PayWi…
vinistevam 6abf05c
feat: integrate selected token functionality into crypto payment section
vinistevam 6f5208b
Merge branch 'main' into vs/pay-with-crypto-section
vinistevam 27345ad
Merge branch 'vs/pay-with-crypto-section' into vs/pay-with-selected-t…
vinistevam baac1a7
feat: implement useDismissOnPayTokenChange hook to manage navigation …
vinistevam 12ae98b
update docs
vinistevam 2467418
Merge branch 'main' into vs/pay-with-crypto-section
vinistevam 7fdd17a
feat: enhance payment token handling by resolving preferred token bas…
vinistevam 83d4850
feat: implement last used payment method functionality and related tests
vinistevam 085b0ff
Merge branch 'main' into vs/pay-with-crypto-section
vinistevam a7032ee
Merge branch 'main' into vs/pay-with-crypto-section
vinistevam 10d383f
Merge branch 'vs/pay-with-crypto-section' into vs/pay-with-selected-t…
vinistevam 5dd5023
Merge branch 'vs/pay-with-selected-token' into vs/pay-with-last-used
vinistevam afe3d52
Merge branch 'main' into vs/pay-with-selected-token
vinistevam 81ccdef
Merge branch 'vs/pay-with-selected-token' into vs/pay-with-last-used
vinistevam 13ea3cd
refactor: extract findLatestMetaMaskPayToken function for better reus…
vinistevam d2907d0
feat: add temporary feature gate for Pay With bottom sheet UI
vinistevam 54867b3
feat: implement Pay With Perps section and related functionality
vinistevam 58870a6
small fixes
vinistevam 5ba9b00
Merge branch 'main' into vs/pay-with-selected-token
vinistevam 401c2bf
Merge branch 'vs/pay-with-selected-token' into vs/pay-with-last-used
vinistevam 6875c0d
Merge branch 'main' into vs/pay-with-last-used
vinistevam 9f573ad
Merge branch 'vs/pay-with-last-used' into vs/pay-with-perps-section
vinistevam 78fcae0
Merge branch 'main' into vs/pay-with-perps-section
vinistevam f0e090f
feat: enhance payment token handling in Pay With Crypto and Perps sec…
vinistevam feeb4dc
Merge branch 'main' into vs/pay-with-perps-section
vinistevam fd3e5c2
Merge branch 'main' into vs/pay-with-perps-section
vinistevam a48c3de
feat: enhance usePerpsBalanceTokenFilter to apply allowlist filter wi…
vinistevam 8663914
feat: implement dismissOnSelectCount for improved navigation in PayWi…
vinistevam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| export { usePayWithCryptoSection } from './usePayWithCryptoSection'; | ||
| export { usePayWithFiatSection } from './usePayWithFiatSection'; | ||
| export { usePayWithPerpsSection } from './usePayWithPerpsSection'; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
X button fails to dismiss modal when dismissOnSelectCount exceeds one
Medium Severity
When
dismissOnSelectCountis greater than 1 (i.e. when opened from "Other assets" in the new PayWithBottomSheet),shouldNavigateBackisfalse, which prevents the BottomSheet from callinggoBack()on any dismiss action. Token selection works because theonClosedcallback dispatchesStackActions.pop(N). However, the X-button close handler callsclose()without a callback, so after the close animation completes, no navigation occurs — thePayWithModalscreen stays in the navigation stack invisibly, causing stack pollution and potential navigation issues on subsequent interactions.Additional Locations (1)
app/components/Views/confirmations/components/modals/pay-with-modal/pay-with-modal.tsx#L276-L277Reviewed by Cursor Bugbot for commit 8663914. Configure here.