Skip to content

feat: batch sell quote details and final review modal #30157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
infiniteflower wants to merge 8 commits into
base: swaps-4439-batchSell-quotes-2
Choose a base branch
from

chore: rename fn

326a6bf
Select commit
Loading
Failed to load commit list.
Draft

feat: batch sell quote details and final review modal #30157

chore: rename fn
326a6bf
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded May 15, 2026 in 1m 53s

Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 141 in app/components/UI/Bridge/components/BatchSellFinalReviewModal/index.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Mark the props of the component as read-only. 

See more on https://sonarcloud.io/project/issues?id=metamask-mobile&issues=AZ4n0WET5c-HxBGEXcPT&open=AZ4n0WET5c-HxBGEXcPT&pullRequest=30157

Check warning on line 35 in app/components/UI/Bridge/components/BatchSellQuoteDetailsModal/BatchSellQuoteDetails.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Mark the props of the component as read-only. 

See more on https://sonarcloud.io/project/issues?id=metamask-mobile&issues=AZ4nQYy5I8TKFvtCvAc-&open=AZ4nQYy5I8TKFvtCvAc-&pullRequest=30157

Check warning on line 144 in app/components/UI/Bridge/components/BatchSellQuoteDetailsModal/BatchSellQuoteDetails.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=metamask-mobile&issues=AZ4jYk7PWK2aw_oojq2f&open=AZ4jYk7PWK2aw_oojq2f&pullRequest=30157

Check warning on line 46 in app/components/UI/Bridge/components/BatchSellFinalReviewModal/index.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Mark the props of the component as read-only. 

See more on https://sonarcloud.io/project/issues?id=metamask-mobile&issues=AZ4n0WET5c-HxBGEXcPR&open=AZ4n0WET5c-HxBGEXcPR&pullRequest=30157

Check warning on line 98 in app/components/UI/Bridge/components/BatchSellQuoteDetailsModal/BatchSellQuoteDetails.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Mark the props of the component as read-only. 

See more on https://sonarcloud.io/project/issues?id=metamask-mobile&issues=AZ4jYk7PWK2aw_oojq2e&open=AZ4jYk7PWK2aw_oojq2e&pullRequest=30157

Check warning on line 175 in app/components/UI/Bridge/components/BatchSellQuoteDetailsModal/BatchSellQuoteDetails.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Mark the props of the component as read-only. 

See more on https://sonarcloud.io/project/issues?id=metamask-mobile&issues=AZ4jYk7PWK2aw_oojq2g&open=AZ4jYk7PWK2aw_oojq2g&pullRequest=30157

Check warning on line 82 in app/components/UI/Bridge/components/BatchSellFinalReviewModal/index.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Mark the props of the component as read-only. 

See more on https://sonarcloud.io/project/issues?id=metamask-mobile&issues=AZ4n0WET5c-HxBGEXcPS&open=AZ4n0WET5c-HxBGEXcPS&pullRequest=30157
View more details on SonarQubeCloud