Skip to content

feat(money-account): add real activity to the money account #30175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shane-t wants to merge 13 commits into
base: main
Choose a base branch
from

feat(money-account): add real activity to the money account

ae93e56
Select commit
Loading
Failed to load commit list.
Open

feat(money-account): add real activity to the money account #30175

feat(money-account): add real activity to the money account
ae93e56
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 15, 2026 in 1m 51s

Quality Gate failed

Failed conditions
45.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 67 in app/components/UI/Money/components/MoneyActivityItem/MoneyActivityItem.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=metamask-mobile&issues=AZ4rBg1uJOticlVzmq7v&open=AZ4rBg1uJOticlVzmq7v&pullRequest=30175

Check warning on line 160 in app/components/UI/Money/hooks/useMoneyTransactionDisplayInfo.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=metamask-mobile&issues=AZ4mDB7ahUm3UEh_UdXK&open=AZ4mDB7ahUm3UEh_UdXK&pullRequest=30175

Check warning on line 136 in app/components/UI/Money/components/MoneyActivityItem/MoneyActivityItem.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=metamask-mobile&issues=AZ4rBg1uJOticlVzmq7w&open=AZ4rBg1uJOticlVzmq7w&pullRequest=30175

Check warning on line 37 in app/components/UI/Money/components/MoneyTransactionDetailsSheet/MoneyTransactionDetailsSheet.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=metamask-mobile&issues=AZ4mlVXh_9oVCvgyEILv&open=AZ4mlVXh_9oVCvgyEILv&pullRequest=30175

Check warning on line 59 in app/components/UI/Money/components/MoneyActivityItem/MoneyActivityItem.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=metamask-mobile&issues=AZ4rBg1uJOticlVzmq7u&open=AZ4rBg1uJOticlVzmq7u&pullRequest=30175

Check warning on line 161 in app/components/UI/Money/hooks/useMoneyTransactionDisplayInfo.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=metamask-mobile&issues=AZ4mDB7ahUm3UEh_UdXL&open=AZ4mDB7ahUm3UEh_UdXL&pullRequest=30175
View more details on SonarQubeCloud