Skip to content

fix(Rewards): Update theMiracle logo and make it theme-aware cp-7.78.0#30213

Merged
Montoya merged 2 commits into
mainfrom
RWDS-1302-themiracle-logo-fix
May 15, 2026
Merged

fix(Rewards): Update theMiracle logo and make it theme-aware cp-7.78.0#30213
Montoya merged 2 commits into
mainfrom
RWDS-1302-themiracle-logo-fix

Conversation

@Montoya
Copy link
Copy Markdown
Contributor

@Montoya Montoya commented May 14, 2026

Description

The logo for theMiracle displayed at the bottom of the Benefits screen was incorrect and was hard to see in dark theme

This uses the updated, correct logo as an SVG and swaps the color when in dark mode.

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/RWDS-1302

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Simulator Screenshot - iPhone 16e - 2026-05-15 at 11 03 13

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk UI-only change: swaps an SVG asset and passes a theme-derived color prop to improve contrast; minimal logic impact covered by unit test updates.

Overview
Updates the Rewards Benefits footer to render the TheMiracle logo using the current theme text color by wiring useTheme() into TheMiracleFooter and passing a color prop to the SVG component.

Replaces themiracle-logo.svg with the corrected artwork and adjusts the unit test to mock/verify the new color prop is set to colors.text.default.

Reviewed by Cursor Bugbot for commit 0ee0184. Bugbot is set up for automated code reviews on this repo. Configure here.

@metamaskbotv2 metamaskbotv2 Bot added the team-rewards Rewards team label May 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Montoya Montoya changed the title Update theMiracle logo and make it theme-aware fix(Rewards): Update theMiracle logo and make it theme-aware May 14, 2026
@Montoya Montoya changed the title fix(Rewards): Update theMiracle logo and make it theme-aware fix(Rewards): Update theMiracle logo and make it theme-aware cp-7.78.0 May 14, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.86%. Comparing base (3751d9a) to head (d33c2bd).
⚠️ Report is 211 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #30213      +/-   ##
==========================================
+ Coverage   81.54%   81.86%   +0.32%     
==========================================
  Files        5343     5434      +91     
  Lines      142128   144899    +2771     
  Branches    32411    33093     +682     
==========================================
+ Hits       115899   118625    +2726     
+ Misses      18299    18162     -137     
- Partials     7930     8112     +182     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are limited to three files within the Rewards/Benefits UI feature area:

  1. TheMiracleFooter.tsx - A small presentational component that renders a "Powered by TheMiracle" footer with an SVG logo. It has no side effects, no state management, no navigation changes, and no controller interactions.
  2. TheMiracleFooter.test.tsx - Unit tests for the above component (not E2E tests).
  3. themiracle-logo.svg - A new static SVG asset.

The component is only imported by BenefitsFullView.tsx within the same Rewards feature. There are no changes to:

  • Shared navigation components (TabBar, modals, bottom sheets)
  • Controllers or Engine
  • E2E test infrastructure
  • Critical user flows (confirmations, swaps, accounts, etc.)

This is a low-risk, isolated UI addition. No E2E test tags are warranted as none of the available tags cover the Rewards/Benefits feature specifically, and the changes don't affect any shared components that could break existing E2E tests.

Performance Test Selection:
The changes are purely cosmetic UI additions (a small footer component with a static SVG logo). There is no impact on rendering performance of lists, data loading, state management, or any critical user flows. No performance tests are warranted.

View GitHub Actions results

@Montoya Montoya marked this pull request as ready for review May 15, 2026 15:05
@Montoya Montoya requested a review from a team as a code owner May 15, 2026 15:05
@sonarqubecloud
Copy link
Copy Markdown

@Montoya Montoya added this pull request to the merge queue May 15, 2026
Merged via the queue into main with commit ea0f772 May 15, 2026
71 checks passed
@Montoya Montoya deleted the RWDS-1302-themiracle-logo-fix branch May 15, 2026 18:42
@github-actions github-actions Bot locked and limited conversation to collaborators May 15, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.79.0 Issue or pull request that will be included in release 7.79.0 label May 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.79.0 Issue or pull request that will be included in release 7.79.0 size-S team-rewards Rewards team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants