Skip to content

fix(predict): fix Add Funds and Withdraw navigation when rendered inside Discovery Tabs #30271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vinnyhoward wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(predict): fix Add Funds and Withdraw navigation when rendered inside Discovery Tabs #30271

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0276b38
fix(predict): pass navigationStack to deposit/withdraw hooks when ren…
vinnyhoward May 15, 2026
2fa2580
fix: remove prop/args for specific stack. not needed
vinnyhoward May 15, 2026
cebaecf
Merge branch 'main' into fix-753-predict-funds-broken-route
vinnyhoward May 15, 2026
c5102be
fix: update test
vinnyhoward May 15, 2026
a8fa2da
Merge branch 'fix-753-predict-funds-broken-route' of github.com:MetaM…
vinnyhoward May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...nts/UI/Predict/components/PredictWorldCupMainFeedBanner/PredictWorldCupMainFeedBanner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,9 @@ const PredictWorldCupMainFeedBanner: React.FC<
);

const handlePress = useCallback(() => {
navigation.navigate(Routes.PREDICT.WORLD_CUP);
navigation.navigate(Routes.PREDICT.ROOT, {
screen: Routes.PREDICT.WORLD_CUP,
});
Comment thread
cursor[bot] marked this conversation as resolved.
}, [navigation]);

if (!imageSource) {
Expand Down
2 changes: 2 additions & 0 deletions app/components/UI/Predict/hooks/usePredictDeposit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { usePredictDeposit } from './usePredictDeposit';
import Engine from '../../../../core/Engine';
import Logger from '../../../../util/Logger';
import { ConfirmationLoader } from '../../../Views/confirmations/components/confirm/confirm-component';
import Routes from '../../../../constants/navigation/Routes';

const mockGoBack = jest.fn();
const mockNavigateToConfirmation = jest.fn();
Expand Down Expand Up @@ -155,6 +156,7 @@ describe('usePredictDeposit', () => {
// Assert
expect(mockNavigateToConfirmation).toHaveBeenCalledWith({
loader: ConfirmationLoader.CustomAmount,
stack: Routes.PREDICT.ROOT,
});
});

Expand Down
2 changes: 2 additions & 0 deletions app/components/UI/Predict/hooks/usePredictDeposit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import Logger from '../../../../util/Logger';
import { useAppThemeFromContext } from '../../../../util/theme';
import { ConfirmationLoader } from '../../../Views/confirmations/components/confirm/confirm-component';
import { useConfirmNavigation } from '../../../Views/confirmations/hooks/useConfirmNavigation';
import Routes from '../../../../constants/navigation/Routes';
import { PREDICT_CONSTANTS } from '../constants/errors';
import { selectPredictPendingDepositByAddress } from '../selectors/predictController';
import {
Expand Down Expand Up @@ -46,6 +47,7 @@ export const usePredictDeposit = () => {
try {
navigateToConfirmation({
loader: ConfirmationLoader.CustomAmount,
stack: Routes.PREDICT.ROOT,
});

depositWithConfirmation({}).catch((err) => {
Expand Down
2 changes: 2 additions & 0 deletions app/components/UI/Predict/hooks/usePredictWithdraw.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { renderHook } from '@testing-library/react-native';
import { usePredictWithdraw } from './usePredictWithdraw';
import { ConfirmationLoader } from '../../../Views/confirmations/components/confirm/confirm-component';
import Routes from '../../../../constants/navigation/Routes';

import { POLYMARKET_PROVIDER_ID } from '../providers/polymarket/constants';
// Create mock functions
Expand Down Expand Up @@ -206,6 +207,7 @@ describe('usePredictWithdraw', () => {

expect(mockNavigateToConfirmation).toHaveBeenCalledWith({
loader: ConfirmationLoader.CustomAmount,
stack: Routes.PREDICT.ROOT,
});
});

Expand Down
2 changes: 2 additions & 0 deletions app/components/UI/Predict/hooks/usePredictWithdraw.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
} from '../../../../component-library/components/Toast';
import { strings } from '../../../../../locales/i18n';
import { selectPredictWithdrawTransaction } from '../selectors/predictController';
import Routes from '../../../../constants/navigation/Routes';

export const usePredictWithdraw = () => {
const { prepareWithdraw } = usePredictTrading();
Expand All @@ -24,6 +25,7 @@ export const usePredictWithdraw = () => {
try {
navigateToConfirmation({
loader: ConfirmationLoader.CustomAmount,
stack: Routes.PREDICT.ROOT,
});

const response = await prepareWithdraw({});
Expand Down
Loading