Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/auto-rc-ota-build-core.yml
Original file line number Diff line number Diff line change
Expand Up @@ -142,5 +142,4 @@ jobs:
build_commit_sha: ${{ needs.trigger-build.outputs.built_commit_sha }}
build_version: ${{ needs.trigger-build.outputs.semantic_version }}
build_number: ${{ needs.trigger-build.outputs.ios_version_code }}
distribute_external: false
secrets: inherit
4 changes: 2 additions & 2 deletions .github/workflows/build-and-upload-to-testflight.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ on:
type: string
default: 'MetaMask BETA & Release Candidates'
distribute_external:
description: 'Whether to distribute to external testers. Defaults to false; nightly-build.yml relies on the script default (true) so it always distributes externally.'
description: 'Whether to distribute to external testers. (default: false)'
required: false
type: boolean
default: false
Expand Down Expand Up @@ -55,7 +55,7 @@ on:
- 'MM Card Team'
- 'Ramp Provider Testing'
distribute_external:
description: 'Whether to distribute to external testers'
description: 'Whether to distribute to external testers (default: false)'
required: false
type: boolean
default: false
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/nightly-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ jobs:
source_branch: main
environment: exp
testflight_group: 'MetaMask BETA & Release Candidates'
distribute_external: true
secrets: inherit

# ── iOS rc: build + TestFlight upload (after exp for sequential versions) ─
Expand All @@ -43,7 +42,6 @@ jobs:
source_branch: main
environment: rc
testflight_group: 'MetaMask BETA & Release Candidates'
distribute_external: false
secrets: inherit

# ── Android exp: ephemeral branch + build ──────────────────────────────
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/runway-production-builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,5 +65,4 @@ jobs:
build_commit_sha: ${{ needs.build.outputs.built_commit_sha }}
build_version: ${{ needs.build.outputs.semantic_version }}
build_number: ${{ needs.build.outputs.ios_version_code }}
distribute_external: false
secrets: inherit
1 change: 0 additions & 1 deletion .github/workflows/runway-rc-builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ jobs:
build_commit_sha: ${{ needs.build.outputs.built_commit_sha }}
build_version: ${{ needs.build.outputs.semantic_version }}
build_number: ${{ needs.build.outputs.ios_version_code }}
distribute_external: false
secrets: inherit

slack-notification:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/upload-to-testflight.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@ on:
required: true
type: string
distribute_external:
description: 'Whether to distribute to external testers. Set false for nightly/internal builds to avoid expiring previous TestFlight builds.'
description: 'Whether to distribute to external testers. (default: false)'
required: false
type: boolean
default: true
default: false
runner_provider:
description: Runner provider forwarded from the caller
required: false
Expand Down
2 changes: 1 addition & 1 deletion ios/fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ platform :ios do
# Convert groups parameter to array (Fastlane CLI passes strings, not arrays)
groups_param = options[:groups] || ['MetaMask BETA & Release Candidates']
groups = groups_param.is_a?(Array) ? groups_param : [groups_param]
distribute_external = options[:distribute_external].nil? ? true : options[:distribute_external].to_s.downcase == 'true'
distribute_external = options[:distribute_external].nil? ? false : options[:distribute_external].to_s.downcase == 'true'
notify_external_testers = distribute_external

if ipa_path.nil? || ipa_path.empty?
Expand Down
4 changes: 2 additions & 2 deletions scripts/upload-to-testflight.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
# branch - Git branch name (required)
# ipa_path - Optional: Direct path to IPA file (if not provided, uses find-ipa-file.sh)
# testflight_group - Optional: TestFlight external testing group name (default: MetaMask BETA & Release Candidates)
# distribute_external - Optional: Whether to distribute to external testers (default: true)
# distribute_external - Optional: Whether to distribute to external testers (default: false)
#
# Environment variables:
# IPA_PATH - IPA path (set by find-ipa-file.sh if not provided as argument)
Expand All @@ -27,7 +27,7 @@ PIPELINE_NAME="$1"
BRANCH="$2"
LOCAL_IPA_PATH="$3"
TESTFLIGHT_GROUP="${4:-MetaMask BETA & Release Candidates}"
DISTRIBUTE_EXTERNAL="${5:-true}"
DISTRIBUTE_EXTERNAL="${5:-false}"

# Get IPA path: use argument if provided, otherwise use find-ipa-file.sh
if [ -n "$LOCAL_IPA_PATH" ]; then
Expand Down
Loading