feat: save custom gas settings

[pedronfigueiredo]

Summary

• Persist custom gas fee settings from the advanced gas modals.
• Read saved gas preferences when building fee options for send confirmations.
• Wire mobile PreferencesController and TransactionController integration for saved gas fee preferences.

Related PRs

• feat: reintroduce saved gas settings metamask-extension#43317
• feat(transaction-controller): support saved gas fee levels core#8993

Testing

• yarn jest app/components/Views/confirmations/components/modals/advanced-eip1559-modal/advanced-eip1559-modal.test.tsx app/components/Views/confirmations/components/modals/advanced-gas-price-modal/advanced-gas-price-modal.test.tsx app/components/Views/confirmations/hooks/gas/useGasFeeEstimateLevelOptions.test.ts app/components/Views/confirmations/hooks/gas/useGasPriceEstimateOption.test.ts app/components/Views/confirmations/hooks/gas/usePersistGasFeePreference.test.ts app/core/Engine/controllers/preferences-controller-init.test.ts app/core/Engine/controllers/transaction-controller/metrics_properties/gas.test.ts app/core/Engine/controllers/transaction-controller/transaction-controller-init.test.ts (8 suites, 78 tests).

---

Note

Medium Risk
Changes how default and custom gas fees are stored and applied for sends; incorrect lookup or validation could affect fee defaults, though saves are gated on complete custom values and covered by new tests.

Overview
Adds per-account, per-chain persistence for gas choices so confirmations can reuse the user’s last fee level or custom values.

On save, confirmation gas flows call usePersistGasFeePreference, which writes to PreferencesController.setAdvancedGasFee (advancedGasFee is persisted state). Advanced EIP-1559 and legacy gas price modals share useAdvancedGasFeeModal, which blocks save when custom fees are incomplete and persists mapped preferences (e.g. max base / priority fee). Preset estimate levels and gas-price estimate options persist the selected userFeeLevel as well.

TransactionController is upgraded to 69.0.0 and receives a getSavedGasFees hook that reads those preferences for the transaction’s from address and chain. Gas metrics now report dapp_proposed when UserFeeLevel.DAPP_SUGGESTED is selected.

^{Reviewed by Cursor Bugbot for commit 3041ea6. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamask-ci]

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

• PR body does not match pull-request-template.md (one or more section headings are missing). See https://github.com/MetaMask/metamask-mobile/blob/main/.github/scripts/shared/pr-template-checks.ts#L15-L23.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

[dan437]

Can you please add screenshots / video with it and resolve failing checks?

[pedronfigueiredo]

mobile-save-gas-settings.mov

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/​@​metamask/​transaction-controller@​68.4.0 ⏵ 69.0.0	+1		+1	+1

View full report

[socket-security]

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

• npm/@metamask/transaction-controller@69.0.0

View full report

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 0799ea2. Configure here.}

[pedronfigueiredo]

@SocketSecurity ignore npm/@metamask/transaction-controller@69.0.0

[github-actions]

🧪 Flaky unit test detection

Run history flaky detection

View recent run history

Historical failure rate is a hint, not proof — review each suggestion in context. See the flaky-test-detection skill for the full pattern reference and manual audit workflow.

Failures / runs sampled per window:

File	7d	15d	30d
app/core/Engine/controllers/preferences-controller-init.test.ts	0/54	0/182	0/374

AI-detected flaky patterns

app/core/Engine/controllers/preferences-controller-init.test.ts

• J3 — Missing jest.clearAllMocks() / jest.resetAllMocks() (high)
  • The entire describe('PreferencesControllerInit') block has no beforeEach that calls jest.clearAllMocks() or jest.resetAllMocks(). The PreferencesController constructor mock and the controller.update mock accumulate call history across all tests.

This is especially risky in the newly added setAdvancedGasFee describe block: applyUpdate reads updateMock.mock.calls[updateMock.mock.calls.length - 1][0] to retrieve the last update callback. If tests run in a different order (e.g. with --randomize) or if a prior test's update call is not cleared, mock.calls.length - 1 may point to a stale callback from a previous test, causing the wrong state mutation to be applied and the assertion to fail intermittently.

Adding a top-level beforeEach(() => { jest.resetAllMocks(); }) ensures each test starts with a clean mock slate.

• Suggested fix in app/core/Engine/controllers/preferences-controller-init.test.ts:37:

  -describe('PreferencesControllerInit', () => {
  -  it('initializes the controller', () => {
  -    const { controller } = preferencesControllerInit(getInitRequestMock());
  -    expect(controller).toBeInstanceOf(PreferencesController);
  -  });
  -
  -  it('passes the proper arguments to the controller', () => {
  -    preferencesControllerInit(getInitRequestMock());
  -
  -    const controllerMock = jest.mocked(PreferencesController);
  -    expect(controllerMock).toHaveBeenCalledWith({
  +describe('PreferencesControllerInit', () => {
  +  beforeEach(() => {
  +    jest.resetAllMocks();
  +  });
  +
  +  it('initializes the controller', () => {
  +    const { controller } = preferencesControllerInit(getInitRequestMock());
  +    expect(controller).toBeInstanceOf(PreferencesController);
  +  });
  +
  +  it('passes the proper arguments to the controller', () => {
  +    preferencesControllerInit(getInitRequestMock());
  +
  +    const controllerMock = jest.mocked(PreferencesController);
  +    expect(controllerMock).toHaveBeenCalledWith({

This check is informational only and does not block merging.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeSwap, SmokeStake, SmokeWalletPlatform, SmokeMoney, SmokePerps, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, SmokeBrowser, SmokeSnaps
• Selected Performance tags: None (no tests recommended)
• Risk Level: high
• AI Confidence: 100%

click to see 🤖 AI reasoning details

E2E Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/transaction-controller. Running all tests.

Performance Test Selection:
The changes are focused on gas fee preference persistence logic and a TransactionController major version upgrade. While these affect transaction flows, they don't directly impact app launch time, login performance, asset loading, account list rendering, or other performance-measured scenarios. The gas fee changes are user-interaction-driven (modal saves) rather than affecting rendering performance or load times. No performance spec files were changed.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud