feat: implement non prefix ids backwards compatiblity on ramps

[meltingice1337]

Description

Backend ramps entity ids (providers, payment methods, currencies, regions) are migrating from the legacy path form (e.g. /providers/transak) to the canonical, non-prefixed form (e.g. transak). The client had accumulated defensive normalization to strip the legacy prefix, and one comparison that keyed directly off the legacy prefix. Now that provider ids arrive canonical, the normalization is redundant and the prefix-based comparison no longer matches. This PR aligns the ramps client with canonical (non-prefixed) provider ids.

Two mechanical changes:

• Pass provider ids/codes through unchanged. normalizeProviderCode(id) from @metamask/ramps-controller is just id.replace(/^\/providers\//, ''). With canonical ids it is a no-op, so the wrapping calls are removed and the raw id/code is used directly. Affected call sites: BuildQuote.tsx (matching the selected provider against a quote's provider), Checkout.tsx (addPrecreatedOrder provider code), BankDetails.tsx / OrderDetails.tsx / useTransakRouting.ts (the refreshOrder provider code, including the transak-native deposit fallback), useContinueWithQuote.ts (widget provider code), and unifiedOrderProcessor.ts (order provider code).
• Fix the Transak logout detection in the Settings modal (SettingsModal.tsx). isTransakNativeProvider matched on the legacy path prefix '/providers/transak-native', which never matches a canonical transak-native id, so the "Log out of Transak" option would silently disappear once ids went non-prefixed. It now matches the canonical code 'transak-native', still covering the transak-native-staging variant via startsWith.

Tests are updated accordingly: cases that asserted the prefix-stripping behavior are removed, and the Settings modal test now exercises the canonical transak-native code.

Changelog

CHANGELOG entry: Fixed the ramps Settings "Log out of Transak" option and provider-code handling so they keep working after backend provider ids move to the non-prefixed format.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/TRAM-3560

Manual testing steps

Feature: Ramps client works with non-prefixed (canonical) provider ids

  Scenario: Transak logout option shows for a canonical provider id
    Given I am authenticated with Transak
    And the selected provider id is the canonical form ("transak-native" or "transak-native-staging")
    When I open the ramps Settings modal
    Then the "Log out of Transak" option is visible

  Scenario: Non-Transak provider does not show the logout option
    Given the selected provider id is a non-Transak canonical id (e.g. "moonpay")
    When I open the ramps Settings modal
    Then the "Log out of Transak" option is not shown

  Scenario: Buy flow selects the matching quote across canonical ids
    Given the provider catalog and quotes return canonical provider ids ("transak")
    When I select a provider on the Build Quote screen
    Then the quote whose provider matches the selected provider is used

  Scenario: Order refresh and creation flow through canonical codes
    Given an order references a canonical provider id
    When I open Order Details / Bank Details and refresh, or create a precreated order at Checkout
    Then the provider code is passed through unchanged and the order refreshes/creates successfully

Screenshots/Recordings

N/A — no new UI. The only user-visible effect is that the existing "Log out of Transak" option keeps rendering when the provider id arrives in the non-prefixed form; the remaining changes are internal provider-code plumbing. Behavior is covered by unit tests.

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Medium Risk
Touches buy/checkout/order-refresh paths across ramps; a mismatch between API ids and client assumptions could break quote selection or order polling, though scope is mostly mechanical id plumbing plus one user-visible Settings fix.

Overview
Aligns the ramps UI with canonical, non-prefixed provider ids (e.g. transak instead of /providers/transak) after the backend migration, by bumping @metamask/ramps-controller to ^16.0.0 and stopping client-side prefix stripping.

Provider codes are passed through unchanged everywhere normalizeProviderCode was used: quote matching in Build Quote, Checkout precreated orders, order refresh in Order Details / Bank Details / Transak routing / unified order processor, and continue-with-quote widget flows. Comparisons now use strict equality on the raw id.

Settings modal Transak logout detection no longer keys off the legacy path prefix '/providers/transak-native' (which would never match canonical ids). It now matches the canonical code transak-native, still covering transak-native-staging via startsWith.

Tests drop prefix-normalization scenarios and use canonical mock provider ids.

^{Reviewed by Cursor Bugbot for commit a8e08f0. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/​@​metamask/​ramps-controller@​16.0.0

View full report

[github-actions]

🧪 Flaky unit test detection

Run history flaky detection

View recent run history

Historical failure rate is a hint, not proof — review each suggestion in context. See the flaky-test-detection skill for the full pattern reference and manual audit workflow.

Failures / runs sampled per window:

File	7d	15d	30d
app/components/UI/Ramp/hooks/useTransakRouting.test.ts	0/50	0/178	0/375

AI-detected flaky patterns

app/components/UI/Ramp/hooks/useTransakRouting.test.ts

• J9 — Module-level mutable let bindings not reset in beforeEach (high)
  • Module-level let variables (mockUserRegion, mockSelectedPaymentMethod) are mutated in individual tests (e.g. mockSelectedPaymentMethod = { id: '/payments/bank-transfer', isManualBankTransfer: true }) but only partially reset in beforeEach. This creates test-order dependency that can lead to intermittent failures when tests run in randomized order or under load.
  • Suggested fix in app/components/UI/Ramp/hooks/useTransakRouting.test.ts:

    -let mockUserRegion: unknown = {
    -  country: { currency: 'USD', isoCode: 'US' },
    -  regionCode: 'us-ca',
    -};
    -let mockSelectedPaymentMethod: unknown;
    -let capturedHandleNavigationStateChange: ((state: any) => void) | null = null;
    -
    -// later in describe
    -beforeEach(() => {
    -  jest.clearAllMocks();
    -  capturedHandleNavigationStateChange = null;
    -  (
    -    jest.requireMock('../headless/sessionRegistry').getSession as jest.Mock
    -  ).mockReturnValue(undefined);
    -});
    +let mockUserRegion: unknown = {
    +  country: { currency: 'USD', isoCode: 'US' },
    +  regionCode: 'us-ca',
    +};
    +let mockSelectedPaymentMethod: unknown;
    +let capturedHandleNavigationStateChange: ((state: any) => void) | null = null;
    +
    +beforeEach(() => {
    +  mockUserRegion = {
    +    country: { currency: 'USD', isoCode: 'US' },
    +    regionCode: 'us-ca',
    +  };
    +  mockSelectedPaymentMethod = undefined;
    +  capturedHandleNavigationStateChange = null;
    +  jest.clearAllMocks();
    +  (
    +    jest.requireMock('../headless/sessionRegistry').getSession as jest.Mock
    +  ).mockReturnValue(undefined);
    +});

• J10 — jest.spyOn() without restoreAllMocks()/mockRestore() afterward (medium)
  • Multiple tests use jest.spyOn (e.g. on global.URL in the URL parsing error test, and potentially others via requireMock). The beforeEach only uses clearAllMocks (which does not restore original implementations). Without restoreAllMocks in afterEach, spies leak between tests causing non-deterministic behavior.
  • Suggested fix in app/components/UI/Ramp/hooks/useTransakRouting.test.ts:

    -describe('useTransakRouting', () => {
    -  beforeEach(() => {
    -    jest.clearAllMocks();
    -    capturedHandleNavigationStateChange = null;
    -    (
    -      jest.requireMock('../headless/sessionRegistry').getSession as jest.Mock
    -    ).mockReturnValue(undefined);
    -  });
    -  it('returns expected functions', () => {
    +describe('useTransakRouting', () => {
    +  beforeEach(() => {
    +    jest.clearAllMocks();
    +    capturedHandleNavigationStateChange = null;
    +    (
    +      jest.requireMock('../headless/sessionRegistry').getSession as jest.Mock
    +    ).mockReturnValue(undefined);
    +  });
    +
    +  afterEach(() => {
    +    jest.restoreAllMocks();
    +  });
    +
    +  it('returns expected functions', () => {

This check is informational only and does not block merging.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeSwap, SmokeStake, SmokeWalletPlatform, SmokeMoney, SmokePerps, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, SmokeBrowser, SmokeSnaps
• Selected Performance tags: None (no tests recommended)
• Risk Level: high
• AI Confidence: 100%

click to see 🤖 AI reasoning details

E2E Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/ramps-controller. Running all tests.

Performance Test Selection:
The changes are focused on provider code normalization logic in the Ramp feature - removing the normalizeProviderCode function and using raw provider IDs directly. These are functional/correctness changes, not performance-sensitive changes. No performance test scenarios (account list, onboarding, login, swaps, launch, asset loading, predict, perps) are impacted by these changes.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud