fix(bridge): remove redundant useElevatedSurface from Bridge modals (TMCU-1039)

[georgewrmarshall]

Description

MMDS BottomSheet now applies the pure-black elevated surface internally, so Bridge modals no longer need the useElevatedSurface() shim (twClassName={surfaceClass}).

This PR removes the redundant hook import, surfaceClass variable, and twClassName prop from all eight Bridge-owned bottom sheet modals listed in TMCU-1039.

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/TMCU-1039

Manual testing steps

N/A — mechanical cleanup only. BottomSheet already owns elevated-surface styling; no visual or behavioral logic changed beyond removing duplicate twClassName wiring.

Screenshots/Recordings

N/A — no visual change expected; elevated surface styling is now sourced solely from MMDS BottomSheet.

Before

N/A

After

N/A

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

  

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeSwap, SmokeConfirmations
• Selected Performance tags: None (no tests recommended)
• Risk Level: low
• AI Confidence: 90%

click to see 🤖 AI reasoning details

E2E Test Selection:
All 8 changed files are Bridge/Swap UI modal components. The changes are uniform and minimal: removing the useElevatedSurface hook import, its usage, and the twClassName={surfaceClass} prop from BottomSheet components. This is a theming/visual change that removes an elevated surface styling from bottom sheet modals in the swap/bridge flow.

The affected components are:

• BatchSellDestinationTokenSelectorModal, BatchSellFinalReviewModal, BatchSellMinimumReceivedInfoModal, BatchSellNetworkFeeInfoModal, BatchSellQuoteDetailsModal — all part of the batch sell (swap) flow
• HighRateAlertModal, MissingPriceModal, PriceImpactModal — warning/info modals in the swap/bridge flow

These changes affect the swap/bridge user flow, so SmokeSwap is the primary tag. Per SmokeSwap's description, SmokeConfirmations should also be selected since swap flows involve transaction confirmations. No other flows (staking, accounts, network, browser, snaps, etc.) are affected. The changes are low risk — they remove a styling prop, not business logic — but should be validated to ensure the bottom sheets still render correctly without the elevated surface class.

Performance Test Selection:
The changes are purely UI/theming — removing a CSS class prop from BottomSheet components in swap/bridge modals. This has no meaningful impact on app performance metrics like render times, load times, or transaction execution speed. No performance tests are warranted.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[georgewrmarshall]

MMDS BottomSheetDialog applies elevated surface styling internally since design-system-react-native 0.33, so twClassName={surfaceClass} was redundant at every Bridge modal callsite. useElevatedSurface returned bg-alternative in pure-black dark mode, matching what BottomSheetDialog now sets via usePureBlack. The other seven Bridge files in this PR are the same deletion with no additional behavior change.