Skip to content

fix(TMCU-1048): Remove redundant useElevatedSurface from MMDS BottomSheet callsites#33159

Merged
georgewrmarshall merged 1 commit into
mainfrom
cursor/remove-elevated-surface-shim-902f
Jul 13, 2026
Merged

fix(TMCU-1048): Remove redundant useElevatedSurface from MMDS BottomSheet callsites#33159
georgewrmarshall merged 1 commit into
mainfrom
cursor/remove-elevated-surface-shim-902f

Conversation

@georgewrmarshall

@georgewrmarshall georgewrmarshall commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Description

MMDS BottomSheet now handles pure-black elevated surface styling internally. This PR removes the redundant useElevatedSurface() shim and twClassName prop from the two remaining accounts-engineer callsites scoped in TMCU-1048.

Changes:

  • ConfirmTurnOnBackupAndSyncModal — removed useElevatedSurface import/usage and twClassName on BottomSheet
  • LearnMoreBottomSheet — removed useElevatedSurface import/usage and twClassName on BottomSheet

Changelog

CHANGELOG entry: null

Related issues

Fixes: TMCU-1048

Manual testing steps

Feature: Pure black elevated surface on MMDS BottomSheet

  Scenario: Backup and sync confirm sheet renders with correct surface
    Given the app is in dark mode with pure black preview enabled
    When the user opens the backup and sync confirmation bottom sheet
    Then the bottom sheet surface should use the elevated background (not collapse into pure black)

  Scenario: Multichain intro learn-more sheet renders with correct surface
    Given the app is in dark mode with pure black preview enabled
    When the user opens the multichain accounts learn-more bottom sheet
    Then the bottom sheet surface should use the elevated background (not collapse into pure black)

N/A for automated cloud-agent environment — visual QA requires device/simulator with pure black preview enabled.

Screenshots/Recordings

N/A — visual surface change only; requires device QA with pure black preview enabled per acceptance criteria.

Before

N/A

After

Backup and Sync BottomSheet background color still works as expected

Screenshot 2026-07-13 at 11 25 33 AM

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Open in Web Open in Cursor 

…heet callsites

MMDS BottomSheet now handles pure-black elevated surface internally.
Remove the useElevatedSurface shim and twClassName prop from:
- ConfirmTurnOnBackupAndSyncModal
- LearnMoreBottomSheet

Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
@metamask-ci metamask-ci Bot added the team-design-system All issues relating to design system in Mobile label Jul 10, 2026
@metamask-ci

metamask-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

  • Pre-merge author checklist has unchecked items (e.g. "I've tested on Android"). Every box must be consciously checked — see docs/readme/ready-for-review.md.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 88%
click to see 🤖 AI reasoning details

E2E Test Selection:
Both changed files contain purely UI/styling changes — removing the useElevatedSurface hook and its twClassName prop from two bottom sheet components:

  1. ConfirmTurnOnBackupAndSyncModal.tsx: Part of the Backup & Sync flow (profile sync). The change removes elevated surface styling from the bottom sheet wrapper. No functional logic is altered.

  2. LearnMoreBottomSheet.tsx: Part of the Multichain Accounts intro modal. Same cosmetic change — removes elevated surface styling.

These are near-cosmetic changes (removing a theme utility class from a UI wrapper). No controller logic, navigation, data flow, or functional behavior is changed. The risk is very low.

SmokeAccounts is selected because it covers profile sync flows (Backup and Sync) and multi-account management, which is directly related to both changed components. The ConfirmTurnOnBackupAndSyncModal is part of the backup/sync enable flow tested under SmokeAccounts, and LearnMoreBottomSheet is part of the multichain accounts intro which also falls under account management flows.

No performance tests are warranted as these are purely styling/cosmetic changes with no impact on rendering performance, data fetching, or app launch times.

Performance Test Selection:
The changes are purely cosmetic — removing a theme utility hook (useElevatedSurface) and its associated twClassName prop from two bottom sheet components. This has no impact on app performance, rendering times, data fetching, or any performance-sensitive flows.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown


return (
<BottomSheet ref={bottomSheetRef} twClassName={surfaceClass}>
<BottomSheet ref={bottomSheetRef}>

@georgewrmarshall georgewrmarshall Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MMDS BottomSheetDialog applies elevated surface styling internally since design-system-react-native 0.33 (background.alternative via usePureBlack when MM_PURE_BLACK_PREVIEW is on). useElevatedSurface returned bg-alternative in that same mode, so removing twClassName does not change the sheet surface. LearnMoreBottomSheet is the same pattern.

@georgewrmarshall georgewrmarshall marked this pull request as ready for review July 13, 2026 17:53
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner July 13, 2026 17:53
@github-actions github-actions Bot added the risk:low AI analysis: low risk label Jul 13, 2026
@georgewrmarshall georgewrmarshall self-assigned this Jul 13, 2026
@georgewrmarshall georgewrmarshall added this pull request to the merge queue Jul 13, 2026
Merged via the queue into main with commit 27cb370 Jul 13, 2026
173 checks passed
@georgewrmarshall georgewrmarshall deleted the cursor/remove-elevated-surface-shim-902f branch July 13, 2026 19:41
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 13, 2026
@metamask-ci metamask-ci Bot added the release-8.4.0 Issue or pull request that will be included in release 8.4.0 label Jul 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-8.4.0 Issue or pull request that will be included in release 8.4.0 risk:low AI analysis: low risk size-XS team-design-system All issues relating to design system in Mobile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants