Skip to content

fix(TMCU-1048): Remove redundant useElevatedSurface from MMDS BottomSheet callsites #33159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgewrmarshall merged 1 commit into from
Jul 13, 2026
+1 −7
Merged

fix(TMCU-1048): Remove redundant useElevatedSurface from MMDS BottomSheet callsites #33159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions ...omponents/UI/Identity/ConfirmTurnOnBackupAndSyncModal/ConfirmTurnOnBackupAndSyncModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,12 @@ import { ConfirmTurnOnBackupAndSyncModalNavigateParams } from '../BackupAndSyncT
import { InteractionManager } from 'react-native';
import useThunkDispatch from '../../../hooks/useThunkDispatch';

import { useElevatedSurface } from '../../../../util/theme/themeUtils';

const ConfirmTurnOnBackupAndSyncModal = () => {
const bottomSheetRef = useRef<BottomSheetRef>(null);
const { enableBackupAndSync, trackEnableBackupAndSyncEvent } =
useParams<ConfirmTurnOnBackupAndSyncModalNavigateParams>();

const dispatch = useThunkDispatch();
const surfaceClass = useElevatedSurface();

const enableBasicFunctionality = async () => {
await dispatch(toggleBasicFunctionality(true));
Expand Down Expand Up @@ -54,7 +51,7 @@ const ConfirmTurnOnBackupAndSyncModal = () => {
};

return (
<BottomSheet ref={bottomSheetRef} twClassName={surfaceClass}>
<BottomSheet ref={bottomSheetRef}>

@georgewrmarshall georgewrmarshall Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MMDS BottomSheetDialog applies elevated surface styling internally since design-system-react-native 0.33 (background.alternative via usePureBlack when MM_PURE_BLACK_PREVIEW is on). useElevatedSurface returned bg-alternative in that same mode, so removing twClassName does not change the sheet surface. LearnMoreBottomSheet is the same pattern.

<ModalContent
title={turnContent.bottomSheetTitle}
message={turnContent.bottomSheetMessage}
Expand Down
3 changes: 0 additions & 3 deletions app/components/Views/MultichainAccounts/IntroModal/LearnMoreBottomSheet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import { RootState } from '../../../../reducers';
import { useDispatch, useSelector } from 'react-redux';
import { setMultichainAccountsIntroModalSeen } from '../../../../actions/user';
import { LEARN_MORE_BOTTOM_SHEET_TEST_IDS } from './LearnMoreBottomSheet.testIds';
import { useElevatedSurface } from '../../../../util/theme/themeUtils';

interface LearnMoreBottomSheetProps {
onClose?: () => void;
Expand All @@ -40,7 +39,6 @@ const LearnMoreBottomSheet: React.FC<LearnMoreBottomSheetProps> = ({
const isBasicFunctionalityEnabled = useSelector(
(state: RootState) => state?.settings?.basicFunctionalityEnabled,
);
const surfaceClass = useElevatedSurface();

const handleBack = useCallback(() => {
sheetRef.current?.onCloseBottomSheet();
Expand Down Expand Up @@ -68,7 +66,6 @@ const LearnMoreBottomSheet: React.FC<LearnMoreBottomSheetProps> = ({
ref={sheetRef}
onClose={onClose}
testID={LEARN_MORE_BOTTOM_SHEET_TEST_IDS.BOTTOM_SHEET}
twClassName={surfaceClass}
>
<View style={styles.container}>
<View style={styles.header}>
Expand Down
Loading