fix(money): remove "Steps" heading for single-step mUSD transfers (MUSD-1160)

[Kureev]

Description

In the Money account activity details, the "Steps (1 completed)" heading was shown even for simple same-network mUSD transfers, where the only "step" is the transaction itself. This implied there were more actions to complete when there were none.

The heading in TransactionDetailsSummary was gated purely on the Money account context. It now also requires more than one rendered step line (child/batch transactions, fiat order line, or source-hash line), so single-step transactions render the progress list without the heading while multi-step flows (convert/bridge withdrawals, fiat deposits, perps/predict deposits) keep it.

While wiring the step count, isSkippedTransaction was found to match only the generic relayDeposit type, while the relay strategy assigns musdRelayDeposit to mUSD conversion deposit children. That filtered the real deposit step out of the list (and would have hidden the heading for genuine multi-step conversions), so the check now uses the shared RELAY_DEPOSIT_TYPES constant, consistent with the line router in the same file.

Changelog

CHANGELOG entry: Fixed the activity details of simple mUSD transfers showing a misleading "Steps" heading

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MUSD-1160

Manual testing steps

Feature: Money account activity details steps heading

  Scenario: user views a simple same-network mUSD transfer
    Given the user has an mUSD Money account with a positive balance

    When user transfers mUSD to another account on the same network and opens the activity details
    Then the transaction row is shown without a "Steps" heading

  Scenario: user views a multi-step withdrawal
    Given the user has an mUSD Money account with a positive balance

    When user withdraws from the Money account to another token/network and opens the activity details
    Then the "Steps (X completed)" heading is shown above the step list

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Low Risk
Localized UI heading logic and deposit-type matching in transaction details, with expanded unit tests and no auth or payment flow changes.

Overview
Money account activity details no longer show "Steps (X completed)" when there is only one step (e.g. simple same-network mUSD transfers). In TransactionDetailsSummary, the steps heading is shown only when the money context applies and there are multiple rendered steps—extra child/batch transactions, a fiat order line, or a source-hash line. Single-step money flows keep the progress list with no section heading (not "Summary" either).

isSkippedTransaction for mUSD conversion parents now treats musdRelayDeposit (via shared RELAY_DEPOSIT_TYPES) as a real deposit step instead of only generic relayDeposit, so conversion deposits stay in the list and multi-step conversions can show the heading and deposit line correctly.

Tests cover multi-step withdraw, single-step (no heading), and mUSD conversion with musdRelayDeposit child.

^{Reviewed by Cursor Bugbot for commit d3acada. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sonarqubecloud]

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

💡 Need a hand with PR review? Try Gitar by Sonar!