-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
chore: relax-price-api-condition-legacy-chart and update to time based index #33204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
218d1ed
chore: relax price API coverage threshold from 95% to 50%
cursoragent 87455a3
feat: time-based x-axis for PriceChart on Token Details Page
cursoragent 7d43cf6
chore: lower MIN_COVERAGE_RATIO to 0.20
sahar-fehri 15c5181
Merge branch 'main' into cursor/price-chart-data-conditions-a279
sahar-fehri c03157b
Merge remote-tracking branch 'origin/main' into cursor/price-chart-da…
sahar-fehri e163eef
Merge branch 'cursor/price-chart-data-conditions-a279' of github.com:…
sahar-fehri fbd6400
test: update coverage threshold tests for 20% MIN_COVERAGE_RATIO
sahar-fehri 4aae39e
test: add coverage for time-based x-axis code in PriceChart and Price…
sahar-fehri 2d0353c
chore: export findNearestIndex for test coverage
sahar-fehri dd06940
test: replace Date.now() with fixed timestamps in tests
sahar-fehri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIME_PERIOD_MS tells PriceChart how wide the x-axis should be in real time.
Without it, the chart only knows the data points it received — it has no idea what "1D" or "1W" means. So when the API returns 14 hours of data, it would stretch those points across the full width (the old behavior).