Skip to content

poc: libsodium #33377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jiexi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

poc: libsodium #33377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app/components/Nav/Main/MainNavigator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import AppInformation from '../../Views/Settings/AppInformation';
import DeveloperOptions from '../../Views/Settings/DeveloperOptions';
import Contacts from '../../Views/Settings/Contacts';
import FeatureFlagOverride from '../../Views/FeatureFlagOverride';
import LibsodiumPoc from '../../Views/LibsodiumPoc';
import Wallet from '../../Views/Wallet';
import SecurityTrustScreen from '../../UI/SecurityTrust/Views/SecurityTrustScreen';
import AddAsset from '../../Views/AddAsset/AddAsset';
Expand Down Expand Up @@ -1467,6 +1468,11 @@ const MainNavigator = () => {
options={{ headerShown: false }}
/>
)}
<NativeStack.Screen
name={Routes.LIBSODIUM_POC}
component={LibsodiumPoc}
options={{ headerShown: false, ...slideFromRightNativeOptions }}
/>

@cursor cursor Bot Jul 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

POC route lacks production guard

Low Severity

The wallet entry to LibsodiumPoc is hidden when METAMASK_ENVIRONMENT is production, but MainNavigator always registers Routes.LIBSODIUM_POC. That mismatch leaves the screen reachable in production via navigation while the adjacent FeatureFlagOverride route uses the same env guard.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 493aa06. Configure here.

<NativeStack.Screen
name="DeFiProtocolPositionDetails"
component={DeFiProtocolPositionDetails}
Expand Down
Loading
Loading