Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: overwrite hardcoded dappid #1060

Closed
wants to merge 1 commit into from
Closed

feat: overwrite hardcoded dappid #1060

wants to merge 1 commit into from

Conversation

abretonc7s
Copy link
Collaborator

@abretonc7s abretonc7s commented Oct 2, 2024

Explanation

Overwrite 'sdk' on userId to avoid hotsharding.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@abretonc7s abretonc7s requested a review from a team as a code owner October 2, 2024 09:33
@abretonc7s abretonc7s enabled auto-merge (squash) October 2, 2024 09:46
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.16%. Comparing base (bf8ebd1) to head (2759f77).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1060   +/-   ##
=======================================
  Coverage   78.16%   78.16%           
=======================================
  Files         179      179           
  Lines        4153     4153           
  Branches     1020     1020           
=======================================
  Hits         3246     3246           
  Misses        907      907           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 2, 2024

@abretonc7s abretonc7s closed this Oct 3, 2024
auto-merge was automatically disabled October 3, 2024 10:59

Pull request was closed

@abretonc7s abretonc7s deleted the overwritedappid branch October 3, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants