Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: no sdk dappid #1062

Merged
merged 3 commits into from
Oct 3, 2024
Merged

feat: no sdk dappid #1062

merged 3 commits into from
Oct 3, 2024

Conversation

abretonc7s
Copy link
Collaborator

@abretonc7s abretonc7s commented Oct 3, 2024

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@abretonc7s abretonc7s requested a review from a team as a code owner October 3, 2024 09:56
BjornGunnarsson
BjornGunnarsson previously approved these changes Oct 3, 2024
@abretonc7s abretonc7s enabled auto-merge (squash) October 3, 2024 10:00
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.16%. Comparing base (9fd87b7) to head (84264f8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1062   +/-   ##
=======================================
  Coverage   78.16%   78.16%           
=======================================
  Files         179      179           
  Lines        4153     4153           
  Branches     1020     1020           
=======================================
  Hits         3246     3246           
  Misses        907      907           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@christopherferreira9 christopherferreira9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was previously approved

@abretonc7s abretonc7s merged commit 29689be into main Oct 3, 2024
9 checks passed
@abretonc7s abretonc7s deleted the nosdkdappid branch October 3, 2024 10:28
Copy link

sonarcloud bot commented Oct 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants