Skip to content

Analytics client v2 #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: ab/analytics-client
Choose a base branch
from

Conversation

ecp4224
Copy link
Collaborator

@ecp4224 ecp4224 commented Apr 17, 2025

Explanation

This PR branches off of #1263 to add the v2 analytics client to @metamask/analytics-client

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@ecp4224 ecp4224 assigned ecp4224 and chakra-guy and unassigned ecp4224 Apr 17, 2025
Copy link

socket-security bot commented Apr 17, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​openapi-fetch@​0.13.510010010091100

View full report

@abretonc7s abretonc7s force-pushed the ab/analytics-client branch from 035fd99 to 4d800d3 Compare April 21, 2025 09:40
@ecp4224 ecp4224 force-pushed the edkek/feat/analytics-client-v2 branch from 6a57f75 to 3fd4e31 Compare April 22, 2025 13:51
Copy link

Caution

Review the following alerts detected in dependencies.

According to your organization's Security Policy, you must resolve all "Block" alerts before proceeding. Learn more about Socket for GitHub.

Action Severity Alert (click for details)
Block Medium
npm/[email protected] has Network access.

Module: globalThis["fetch"]

Location: Package overview

Source: packages/analytics-client/package.json

ℹ Read more on: This package | This alert | What is network access?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants