Skip to content

feat: allow fixtures on E2E #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

christopherferreira9
Copy link
Collaborator

@christopherferreira9 christopherferreira9 commented Apr 23, 2025

Explanation

This PR aims to add support for the use of E2E fixtures along with cleaning old references to an old implementation of E2E where multiple SDKs were being involved.
Because the mobile building process for SDK isn't yet automated, this still requires a manual trigger.

Main features of this PR:

  • Allows the usage of Fixtures for Mobile builds containing IS_TEST=true
  • Prioritizes the use of BrowserStack to improve flakiness
  • Simplifies imports to avoid long imports
  • Removes references to unused Test Dapps
  • Uses a new MetaMask SDK Test Dapp for consistency and avoid flakiness

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

Copy link

socket-security bot commented Apr 23, 2025

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert (click for details)
Warn Low
npm/[email protected] is a AI-detected potential code anomaly.

Notes: The code contains anomalies that raise security concerns, such as dynamic require statements, error handling that could be exploited, and potential information disclosure through console messages. Further review and hardening of the code are recommended to mitigate these risks.

Confidence: 1.00

Severity: 0.60

From: e2e/yarn.locknpm/[email protected]

ℹ Read more on: This package | This alert | What is an AI-detected potential code anomaly?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: An AI system found a low-risk anomaly in this package. It may still be fine to use, but you should check that it is safe before proceeding.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.05%. Comparing base (205959d) to head (bdb2422).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1268   +/-   ##
=======================================
  Coverage   74.05%   74.05%           
=======================================
  Files         182      182           
  Lines        4352     4352           
  Branches     1066     1066           
=======================================
  Hits         3223     3223           
  Misses       1129     1129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christopherferreira9 christopherferreira9 changed the title Christopher/update e2e ios simulator feat: allow fixtures on E2E May 5, 2025
Copy link

sonarqubecloud bot commented May 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant