Skip to content

fix(ci): allow check-workflows to be skipped in merge queue skip path#898

Merged
sirtimid merged 1 commit into
mainfrom
sirtimid/fix-check-workflows-always
Mar 26, 2026
Merged

fix(ci): allow check-workflows to be skipped in merge queue skip path#898
sirtimid merged 1 commit into
mainfrom
sirtimid/fix-check-workflows-always

Conversation

@sirtimid

@sirtimid sirtimid commented Mar 26, 2026

Copy link
Copy Markdown
Member

Summary

The all-jobs-complete gate job was failing with "check-workflows did not succeed" during merge queue runs when only CI files changed (failed run).

Root cause: When the merge queue determines a PR is already up-to-date with main (skip-merge-queue=true), check-workflows is intentionally skipped. However, the all-jobs-complete gate unconditionally required check-workflows == success whenever HAS_CI was true, causing a spurious failure.

Fix: Add check-skip-merge-queue as a dependency of all-jobs-complete and skip the check-workflows requirement when skip-merge-queue is true — mirroring the escape hatch that all-jobs-pass already has.

Changes

  • Add check-skip-merge-queue to the needs list of all-jobs-complete so its outputs are accessible
  • Guard the check-workflows assertion with a skip-merge-queue != true condition

Testing

The fix was verified by tracing the exact failure scenario from the merge queue run. The all-jobs-pass job already passed in that run via its own escape hatch, confirming the issue was cosmetic (red X on all-jobs-complete) rather than a merge blocker. This PR makes all-jobs-complete itself behave correctly in this path.

🤖 Generated with Claude Code


Note

Low Risk
Low risk: only adjusts GitHub Actions job gating logic to tolerate an intentionally skipped check-workflows job when skip-merge-queue is true.

Overview
Prevents false CI failures in merge-queue runs where the PR is already up to date and check-workflows is intentionally skipped.

all-jobs-complete now depends on check-skip-merge-queue and only requires check-workflows to have succeeded when skip-merge-queue is not true, aligning the final gate behavior with the merge-queue skip path.

Written by Cursor Bugbot for commit 189a693. This will update automatically on new commits. Configure here.

The `all-jobs-complete` gate required `check-workflows` to succeed
whenever CI files changed, but `check-workflows` is intentionally
skipped when the merge queue determines the PR is already up-to-date.
This caused a spurious failure in the gate job during merge queue runs.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@sirtimid
sirtimid requested a review from a team as a code owner March 26, 2026 18:22
@sirtimid
sirtimid enabled auto-merge March 26, 2026 18:23
@sirtimid
sirtimid added this pull request to the merge queue Mar 26, 2026
Merged via the queue into main with commit 86f03c3 Mar 26, 2026
20 checks passed
@sirtimid
sirtimid deleted the sirtimid/fix-check-workflows-always branch March 26, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants