fix(ci): allow check-workflows to be skipped in merge queue skip path#898
Merged
Conversation
The `all-jobs-complete` gate required `check-workflows` to succeed whenever CI files changed, but `check-workflows` is intentionally skipped when the merge queue determines the PR is already up-to-date. This caused a spurious failure in the gate job during merge queue runs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sirtimid
enabled auto-merge
March 26, 2026 18:23
rekmarks
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
all-jobs-completegate job was failing with"check-workflows did not succeed"during merge queue runs when only CI files changed (failed run).Root cause: When the merge queue determines a PR is already up-to-date with main (
skip-merge-queue=true),check-workflowsis intentionally skipped. However, theall-jobs-completegate unconditionally requiredcheck-workflows == successwheneverHAS_CIwas true, causing a spurious failure.Fix: Add
check-skip-merge-queueas a dependency ofall-jobs-completeand skip thecheck-workflowsrequirement whenskip-merge-queueistrue— mirroring the escape hatch thatall-jobs-passalready has.Changes
check-skip-merge-queueto theneedslist ofall-jobs-completeso its outputs are accessiblecheck-workflowsassertion with askip-merge-queue != trueconditionTesting
The fix was verified by tracing the exact failure scenario from the merge queue run. The
all-jobs-passjob already passed in that run via its own escape hatch, confirming the issue was cosmetic (red X onall-jobs-complete) rather than a merge blocker. This PR makesall-jobs-completeitself behave correctly in this path.🤖 Generated with Claude Code
Note
Low Risk
Low risk: only adjusts GitHub Actions job gating logic to tolerate an intentionally skipped
check-workflowsjob whenskip-merge-queueis true.Overview
Prevents false CI failures in merge-queue runs where the PR is already up to date and
check-workflowsis intentionally skipped.all-jobs-completenow depends oncheck-skip-merge-queueand only requirescheck-workflowsto have succeeded whenskip-merge-queueis nottrue, aligning the final gate behavior with the merge-queue skip path.Written by Cursor Bugbot for commit 189a693. This will update automatically on new commits. Configure here.