Skip to content

chore(deps-dev): bump @metamask/eslint-config from 12.2.0 to 14.1.0 #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dependabot wants to merge 1 commit into from
Closed

chore(deps-dev): bump @metamask/eslint-config from 12.2.0 to 14.1.0 #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"@lavamoat/allow-scripts": "^3.4.0",
"@lavamoat/preinstall-always-fail": "^2.1.1",
"@metamask/create-release-branch": "^4.1.1",
"@metamask/eslint-config": "^12.0.0",
"@metamask/eslint-config": "^15.0.0",

@cursor cursor Bot Dec 7, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Peer dependency mismatch breaks ESLint configuration installation

The @metamask/eslint-config is being updated to ^15.0.0 which requires eslint: ^9.11.0, but the project uses eslint: ^8.56.0. Additionally, @metamask/eslint-config-nodejs@12.1.0 and @metamask/eslint-config-typescript@12.1.0 both have peer dependency on @metamask/eslint-config: ^12.0.0, which is incompatible with version 15. The PR title also indicates updating to 14.1.0, but the actual version being installed is 15.0.0. Several other peer dependencies are also mismatched: eslint-config-prettier requires ^9.1.0 but project has ^8.5.0, and eslint-plugin-promise requires ^7.1.0 but project has ^6.1.1.

Additional Locations (2)

Fix in Cursor Fix in Web

"@metamask/eslint-config-nodejs": "^12.0.0",
"@metamask/eslint-config-typescript": "^12.0.0",
"@types/keccak": "^3.0.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/smart-accounts-kit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@
"@lavamoat/allow-scripts": "^3.4.0",
"@lavamoat/preinstall-always-fail": "^2.1.1",
"@metamask/auto-changelog": "^5.0.2",
"@metamask/eslint-config": "^12.0.0",
"@metamask/eslint-config": "^15.0.0",
"@metamask/eslint-config-nodejs": "^12.0.0",
"@metamask/eslint-config-typescript": "^12.0.0",
"@types/node": "^20.10.6",
Expand Down
43 changes: 30 additions & 13 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,13 @@ __metadata:
languageName: node
linkType: hard

"@eslint/js@npm:^9.11.0":
version: 9.39.1
resolution: "@eslint/js@npm:9.39.1"
checksum: 10/b10b9b953212c0f3ffca475159bbe519e9e98847200c7432d1637d444fddcd7b712d2b7710a7dc20510f9cfbe8db330039b2aad09cb55d9545b116d940dbeed2
languageName: node
linkType: hard

"@ethereumjs/common@npm:^3.2.0":
version: 3.2.0
resolution: "@ethereumjs/common@npm:3.2.0"
Expand Down Expand Up @@ -639,18 +646,21 @@ __metadata:
languageName: node
linkType: hard

"@metamask/eslint-config@npm:^12.0.0":
version: 12.2.0
resolution: "@metamask/eslint-config@npm:12.2.0"
"@metamask/eslint-config@npm:^15.0.0":
version: 15.0.0
resolution: "@metamask/eslint-config@npm:15.0.0"
dependencies:
"@eslint/js": "npm:^9.11.0"
globals: "npm:^15.9.0"
peerDependencies:
eslint: ^8.27.0
eslint-config-prettier: ^8.5.0
eslint-plugin-import: ~2.26.0
eslint-plugin-jsdoc: ^39.6.2 || ^41 || ^43.0.7
eslint-plugin-prettier: ^4.2.1
eslint-plugin-promise: ^6.1.1
prettier: ^2.7.1
checksum: 10/6edbf4c2fce34ba8ccd873938501744d69cd13c02047655df596ab551f1aaa390513b8df855145d04c7fed6b5d91b9cfd0ce96ee082abf838292df761f50c520
eslint: ^9.11.0
eslint-config-prettier: ^9.1.0
eslint-plugin-import-x: ^4.3.0
eslint-plugin-jsdoc: ^50.2.4
eslint-plugin-prettier: ^5.2.1
eslint-plugin-promise: ^7.1.0
prettier: ^3.3.3
checksum: 10/93eb41bd61f3f4a0cf930a3d83e8893455f4f03339e91b21ef5a2835d24532db7c2916138a3e1b64777b5fb95cbe4ac90107697ac6f962c11ea7a99955cc75e4
languageName: node
linkType: hard

Expand All @@ -665,7 +675,7 @@ __metadata:
"@metamask/delegation-abis": "npm:^0.11.0"
"@metamask/delegation-core": "npm:^0.3.0"
"@metamask/delegation-deployments": "npm:^0.15.0"
"@metamask/eslint-config": "npm:^12.0.0"
"@metamask/eslint-config": "npm:^15.0.0"
"@metamask/eslint-config-nodejs": "npm:^12.0.0"
"@metamask/eslint-config-typescript": "npm:^12.0.0"
"@types/node": "npm:^20.10.6"
Expand Down Expand Up @@ -2457,7 +2467,7 @@ __metadata:
"@lavamoat/allow-scripts": "npm:^3.4.0"
"@lavamoat/preinstall-always-fail": "npm:^2.1.1"
"@metamask/create-release-branch": "npm:^4.1.1"
"@metamask/eslint-config": "npm:^12.0.0"
"@metamask/eslint-config": "npm:^15.0.0"
"@metamask/eslint-config-nodejs": "npm:^12.0.0"
"@metamask/eslint-config-typescript": "npm:^12.0.0"
"@types/keccak": "npm:^3.0.4"
Expand Down Expand Up @@ -3680,6 +3690,13 @@ __metadata:
languageName: node
linkType: hard

"globals@npm:^15.9.0":
version: 15.15.0
resolution: "globals@npm:15.15.0"
checksum: 10/7f561c87b2fd381b27fc2db7df8a4ea7a9bb378667b8a7193e61fd2ca3a876479174e2a303a74345fbea6e1242e16db48915c1fd3bf35adcf4060a795b425e18
languageName: node
linkType: hard

"globalthis@npm:^1.0.3":
version: 1.0.4
resolution: "globalthis@npm:1.0.4"
Expand Down
Loading