Consolidate ExecutionMode type and constants to enum#16
Merged
Conversation
e7ba7df to
7384a0e
Compare
hanzel98
previously approved these changes
Jul 9, 2025
hanzel98
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Previously
ExecutionModewas a type, which was implemented as multiple constant literals. Now we combine those two into a single enumExecutionMode.🔄 What Changed?
type ExecutionMode = {...}andconst SINGLE_DEFAULT_MODE = '0x....etc becomesenum ExecutionMode = { SINGLE_DEFAULT = '0x...' ... }/utilsexport to main root export🚀 Why?
The
ExecutionModewas required by a number of interfaces in the root export. This meant that a caller would have to import the function from the root export, and the ExecutionMode constants from the/utilsexport. Additionally, the caller may have to import the type (by name), and each of the constants (by name). Allowing the caller to import only the enum, makes calling these functions much easier.🧪 How to Test?
Sufficient automated testing in unit tests, and e2e integration tests. Review the integration tests to see the new interface. Take special note of the imports.
List any breaking changes:
ExecutionModebecomes an enum and moves from@metamask/delegation-toolkit/utilsto `@metamask/delegation-toolkit.📋 Checklist
Check off completed items:
🔗 Related Issues
Link to related issues:
Closes #
Related to #
📚 Additional Notes
Any additional information, concerns, or context: