Shuffle redelegation actions#229
Merged
Merged
Conversation
- add Action suffix to action names - remove redelegatePermissionContextActions function - add redelegation actions to erc7710WalletActions
jeffsmale90
force-pushed
the
chore/shuffle-redelegation-actions
branch
from
5c62ce5 to
0aa9f00
Compare
mj-kiwi
approved these changes
May 12, 2026
mj-kiwi
left a comment
mj-kiwi
left a comment
Contributor
There was a problem hiding this comment.
Since we changed the action exports, I think this is a breaking change. Should we add it to the changelog?
jeffsmale90
added a commit
that referenced
this pull request
May 12, 2026
jeffsmale90
added a commit
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
To improve consistency with the existing ERC-7710 developer experience, this PR moves the redelegation actions to the
ERC7710WalletActions🔄 What Changed?
Actionsuffix to action namesredelegatePermissionContextActionsfunctionerc7710WalletActionsNote
Medium Risk
Medium risk due to breaking API changes (renamed exports and removal of
redelegatePermissionContextActions) and updated chainId resolution behavior that could affect downstream integrations.Overview
Reshapes the redelegation API for consistency with ERC-7710 client extensions. The standalone redelegation functions are renamed to
redelegatePermissionContextAction/redelegatePermissionContextOpenAction, and the previousredelegatePermissionContextActionsextender is removed.Adds redelegation methods to
erc7710WalletActions. Wallet clients extended viaerc7710WalletActions()now exposeredelegatePermissionContextandredelegatePermissionContextOpen.Makes
chainIdoptional for redelegation. Both redelegation actions now resolvechainIdfromclient.chain.idwhen omitted (and throw if neither is available), with tests updated/expanded to cover inference and error cases.Reviewed by Cursor Bugbot for commit 0aa9f00. Bugbot is set up for automated code reviews on this repo. Configure here.