fix: sendTransactionWithDelegation fails for value transfers#30
Merged
Conversation
jeffsmale90
force-pushed
the
fix/send-value-tx-with-delegation
branch
from
935f685 to
264202b
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jeffsmale90
force-pushed
the
fix/send-value-tx-with-delegation
branch
2 times, most recently
from
274f5f2 to
b298719
Compare
…sulting transaction args, resulting in failed transaction
jeffsmale90
force-pushed
the
fix/send-value-tx-with-delegation
branch
from
b298719 to
6d9143c
Compare
hanzel98
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
When
valueis included in the arguments tosendTransactionWithDelegation, this is encoded into the calldata. This change fixes a bug where this was left in the arguments passed tosendTransactionresulting in value being included in the call toredeemDelegation, and a failing transaction.🔄 What Changed?
valueis no longer included in the args passed tosendTransactionvalueis not passed through🧪 How to Test?
The integration test outlines the end-behaviour being tested.
🔗 Related Issues
Link to related issues:
Closes #28