Skip to content

make startTime in native-token-stream optional#37

Merged
MoMannn merged 1 commit into
mainfrom
core/optional-parameters
Jul 28, 2025
Merged

make startTime in native-token-stream optional#37
MoMannn merged 1 commit into
mainfrom
core/optional-parameters

Conversation

@MoMannn

@MoMannn MoMannn commented Jul 17, 2025

Copy link
Copy Markdown
Member

📝 Description

Make startTime optional. In case its not defined permission snap will set startTime as Date.now() to ensure the current time for user.

🔄 What Changed?

List the specific changes made:

  • startTime set to optional.

🚀 Why?

Explain the motivation behind these changes:

  • Snap will set startTime in case its not set.

🧪 How to Test?

Describe how to test these changes:

  • Manual testing steps:
  1. Use experimental permission action with startTime not set.
  • Automated tests added/updated
  • All existing tests pass

⚠️ Breaking Changes

List any breaking changes:

  • No breaking changes

📋 Checklist

Check off completed items:

  • Code follows the project's coding standards
  • Self-review completed
  • Documentation updated (if needed)
  • Tests added/updated
  • Changelog updated (if needed)
  • All CI checks pass

🔗 Related Issues

Link to related issues:
MetaMask/snap-7715-permissions#110

📚 Additional Notes

/

@MoMannn MoMannn requested a review from a team as a code owner July 17, 2025 13:52

@jeffsmale90 jeffsmale90 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

When we release this change in the SDK, we should ensure we have an updated version of the Snaps released, and update the experimental actions to require the updated snaps to be installed.

@MoMannn MoMannn merged commit a3f4b48 into main Jul 28, 2025
16 checks passed
@MoMannn MoMannn deleted the core/optional-parameters branch July 28, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants