Fix incorrect service availability log#40
Merged
jeffsmale90 merged 1 commit intoJul 23, 2025
Merged
Conversation
Co-authored-by: jeff.smale <jeff.smale@consensys.net>
jeffsmale90
added a commit
that referenced
this pull request
Jul 30, 2025
* Full run e2e on every branch * Fix incorrect caveat config * refactor(e2e): remove build step from CI and improve dependency polling logic, remove explicit turbo cache dir * Add timeout, to fail after dependencies are not available before 5 minutes. Fix issue where dependency is marked as unavailable even when it's responding, if the method is not supported. * Conditionally log service availability to prevent misleading logging (#40) Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: jeff.smale <jeff.smale@consensys.net> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: jeff.smale <jeff.smale@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR fixes a bug in the
waitForfunction where it would incorrectly log that a service is available even when it timed out.🔄 What Changed?
List the specific changes made:
console.log(${name} is available)statement in thewaitForfunction is now conditional.isAvailableistrueupon exiting the loop.🚀 Why?
Explain the motivation behind these changes:
waitForfunction times out.🧪 How to Test?
Describe how to test these changes:
npm run test:e2e).waitForfunction.List any breaking changes:
📋 Checklist
Check off completed items:
🔗 Related Issues
Link to related issues:
Closes #
Related to #
📚 Additional Notes
This change ensures that the logging behavior of the
waitForfunction is consistent with its actual outcome, providing clearer feedback during e2e test runs.Open in Web • Open in Cursor