Skip to content

Fix incorrect service availability log#40

Merged
jeffsmale90 merged 1 commit into
chore/e2e-fullrunfrom
cursor/fix-incorrect-service-availability-log-6e36
Jul 23, 2025
Merged

Fix incorrect service availability log#40
jeffsmale90 merged 1 commit into
chore/e2e-fullrunfrom
cursor/fix-incorrect-service-availability-log-6e36

Conversation

@jeffsmale90

@jeffsmale90 jeffsmale90 commented Jul 23, 2025

Copy link
Copy Markdown
Collaborator

📝 Description

This PR fixes a bug in the waitFor function where it would incorrectly log that a service is available even when it timed out.

🔄 What Changed?

List the specific changes made:

  • The console.log(${name} is available) statement in the waitFor function is now conditional.
  • The log message will only be printed if isAvailable is true upon exiting the loop.

🚀 Why?

Explain the motivation behind these changes:

  • To prevent misleading log output when the waitFor function times out.
  • To ensure that the "service is available" message accurately reflects the service's status.

🧪 How to Test?

Describe how to test these changes:

  • Manual testing steps:
  1. Run the e2e tests (e.g., npm run test:e2e).
  2. Observe the console output for the waitFor function.
  3. Verify that if a service times out, it does not print the "service is available" message.
  4. Verify that if a service successfully becomes available, it does print the "service is available" message.
  • Automated tests added/updated
  • All existing tests pass

⚠️ Breaking Changes

List any breaking changes:

  • No breaking changes
  • Breaking changes (describe below):

📋 Checklist

Check off completed items:

  • Code follows the project's coding standards
  • Self-review completed
  • Documentation updated (if needed)
  • Tests added/updated
  • Changelog updated (if needed)
  • All CI checks pass

🔗 Related Issues

Link to related issues:
Closes #
Related to #

📚 Additional Notes

This change ensures that the logging behavior of the waitFor function is consistent with its actual outcome, providing clearer feedback during e2e test runs.


Open in WebOpen in Cursor

Co-authored-by: jeff.smale <jeff.smale@consensys.net>
@jeffsmale90 jeffsmale90 merged commit 669d40c into chore/e2e-fullrun Jul 23, 2025
11 checks passed
@jeffsmale90 jeffsmale90 deleted the cursor/fix-incorrect-service-availability-log-6e36 branch July 23, 2025 03:56
jeffsmale90 added a commit that referenced this pull request Jul 30, 2025
* Full run e2e on every branch

* Fix incorrect caveat config

* refactor(e2e): remove build step from CI and improve dependency polling logic, remove explicit turbo cache dir

* Add timeout, to fail after dependencies are not available before 5 minutes. Fix issue where dependency is marked as unavailable even when it's responding, if the method is not supported.

* Conditionally log service availability to prevent misleading logging (#40)

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: jeff.smale <jeff.smale@consensys.net>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: jeff.smale <jeff.smale@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants