Skip to content

Added Nonce Enforcer as Caveat in Delegation Core#43

Closed
hanzel98 wants to merge 2 commits into
mainfrom
feat/nonce-caveat-delegation-core
Closed

Added Nonce Enforcer as Caveat in Delegation Core#43
hanzel98 wants to merge 2 commits into
mainfrom
feat/nonce-caveat-delegation-core

Conversation

@hanzel98

@hanzel98 hanzel98 commented Jul 30, 2025

Copy link
Copy Markdown
Contributor

📝 Description

Added the nonce caveat createNonceTerms to the delegation-core

🔄 What Changed?

List the specific changes made:

  • Added the function createNonceTerms to the delegation-core
  • Replaced the old terms creation logic in the nonce caveat builder
  • Updated the tests
  • Fixed an issue with the error messages in the e2e tests

🚀 Why?

Explain the motivation behind these changes:

  • The nonce enforcer terms needed to be part of the delegation-core
  • The e2e were broken because an unnecessary function for the errors.

🧪 How to Test?

Describe how to test these changes:

  • Automated tests added/updated
  • All existing tests pass

⚠️ Breaking Changes

List any breaking changes:

  • No breaking changes
  • Breaking changes (describe below):

📋 Checklist

Check off completed items:

  • Code follows the project's coding standards
  • Self-review completed
  • Documentation updated (if needed)
  • Tests added/updated
  • Changelog updated (if needed)
  • All CI checks pass

🔗 Related Issues

Link to related issues: https://app.zenhub.com/workspaces/readable-permissions-67982ce51eb4360029b2c1a1/issues/gh/metamask/delegator-readable-permissions/305

📚 Additional Notes

This changed required to tests the e2e tests related to the nonce caveat. After testing that an error was found for the e2e related to the function stringToUnprefixedHex so it got deleted for all e2e tests. At this point other non-related e2e are failling

@hanzel98 hanzel98 requested a review from a team as a code owner July 30, 2025 16:31
@hanzel98 hanzel98 marked this pull request as draft July 30, 2025 20:49
@hanzel98 hanzel98 closed this Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant